fix: reorder Flutter SDK check and pubGet execution in PackagesGetCommand (#1285)

* fix: reorder Flutter SDK check and pubGet execution in PackagesGetCommand

* fix: fix formatting on lib/src/commands/packages/commands/get.dart

* test: add test for handling Flutter not installed scenario in packages get command

* Update test/src/commands/packages/commands/get_test.dart

Co-authored-by: Jochum van der Ploeg <[email protected]>

* Update lib/src/commands/packages/commands/get.dart

* fix: improve error message for missing Flutter SDK

* fix: enhance error message for missing Flutter SDK with troubleshooting link

---------

Co-authored-by: Jochum van der Ploeg <[email protected]>

Author: Erengun

lib/src/commands/packages/commands/get.dart

@@ -50,21 +50,27 @@ class PackagesGetCommand extends Command<int> {
     final target = _argResults.rest.length == 1 ? _argResults.rest[0] : '.';
     final targetPath = path.normalize(Directory(target).absolute.path);
     final isFlutterInstalled = await Flutter.installed(logger: _logger);
-    if (isFlutterInstalled) {
-      try {
-        await Flutter.pubGet(
-          cwd: targetPath,
-          recursive: recursive,
-          ignore: ignore,
-          logger: _logger,
-        );
-      } on PubspecNotFound catch (_) {
-        _logger.err('Could not find a pubspec.yaml in $targetPath');
-        return ExitCode.noInput.code;
-      } on Exception catch (error) {
-        _logger.err('$error');
-        return ExitCode.unavailable.code;
-      }
+    if (!isFlutterInstalled) {
+      _logger.err(
+        'Could not find Flutter SDK. '
+        'Please ensure it is installed and added to your PATH. '
+        'For troubleshooting, see https://docs.flutter.dev/install/troubleshoot',
+      );
+      return ExitCode.unavailable.code;
+    }
+    try {
+      await Flutter.pubGet(
+        cwd: targetPath,
+        recursive: recursive,
+        ignore: ignore,
+        logger: _logger,
+      );
+    } on PubspecNotFound catch (_) {
+      _logger.err('Could not find a pubspec.yaml in $targetPath');
+      return ExitCode.noInput.code;
+    } on Exception catch (error) {
+      _logger.err('$error');
+      return ExitCode.unavailable.code;
     }
     return ExitCode.success.code;
   }

test/src/commands/packages/commands/get_test.dart

@@ -7,6 +7,7 @@ import 'package:mocktail/mocktail.dart';
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 import 'package:universal_io/io.dart';
+import 'package:very_good_cli/src/cli/cli.dart';
 
 import '../../../../helpers/helpers.dart';
 
@@ -99,6 +100,58 @@ void main() {
       }),
     );
 
+    test(
+      'returns exit code unavailable when Flutter is not installed',
+      withRunner((commandRunner, logger, pubUpdater, printLogs) async {
+        final tempDirectory = Directory.systemTemp.createTempSync();
+        addTearDown(() => tempDirectory.deleteSync(recursive: true));
+
+        File(path.join(tempDirectory.path, 'pubspec.yaml')).writeAsStringSync(
+          '''
+name: example
+version: 0.1.0
+
+environment:
+sdk: ^3.8.0
+''',
+        );
+
+        // Mock flutter process to simulate flutter not being installed
+        Future<ProcessResult> mockProcess(
+          String executable,
+          List<String> arguments, {
+          String? workingDirectory,
+          bool runInShell = false,
+        }) async {
+          if (executable == 'flutter') {
+            throw Exception('flutter not installed');
+          }
+          return ProcessResult(42, 0, '', '');
+        }
+
+        late int result;
+        await ProcessOverrides.runZoned(
+          () async {
+            result = await commandRunner.run([
+              'packages',
+              'get',
+              tempDirectory.path,
+            ]);
+          },
+          runProcess: mockProcess,
+        );
+
+        expect(result, equals(ExitCode.unavailable.code));
+        verify(() {
+          logger.err(
+            'Could not find Flutter SDK. '
+            'Please ensure it is installed and added to your PATH. '
+            'For troubleshooting, see https://docs.flutter.dev/install/troubleshoot',
+          );
+        }).called(1);
+      }),
+    );
+
     test(
       'ignores .fvm directory',
       withRunner((commandRunner, logger, pubUpdater, printLogs) async {