Skip to content

Commit 973eb41

Browse files
alestiagoalestiago
authored
feat: modified collection progress message on check license (#855)
1 parent 0662587 commit 973eb41

File tree

2 files changed

+52
-18
lines changed

2 files changed

+52
-18
lines changed

‎lib/src/commands/packages/commands/check/commands/licenses.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ class PackagesCheckLicensesCommand extends Command<int> {
162162
final licenses = <String, Set<String>?>{};
163163
for (final dependency in filteredDependencies) {
164164
progress.update(
165-
'Collecting licenses of ${licenses.length}/${filteredDependencies.length} packages.',
165+
'''Collecting licenses from ${licenses.length + 1} out of ${filteredDependencies.length} ${filteredDependencies.length == 1 ? 'package' : 'packages'}''',
166166
);
167167

168168
final dependencyName = dependency.package();

‎test/src/commands/packages/commands/check/commands/licenses_test.dart‎

Lines changed: 51 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,9 @@ void main() {
113113
);
114114

115115
verify(
116-
() => progress.update('Collecting licenses of 0/1 packages.'),
116+
() => progress.update(
117+
'Collecting licenses from 1 out of 1 package',
118+
),
117119
).called(1);
118120
verify(
119121
() => progress.complete(
@@ -145,10 +147,14 @@ void main() {
145147
);
146148

147149
verify(
148-
() => progress.update('Collecting licenses of 0/2 packages.'),
150+
() => progress.update(
151+
'Collecting licenses from 1 out of 2 packages',
152+
),
149153
).called(1);
150154
verify(
151-
() => progress.update('Collecting licenses of 1/2 packages.'),
155+
() => progress.update(
156+
'Collecting licenses from 2 out of 2 packages',
157+
),
152158
).called(1);
153159
verify(
154160
() => progress.complete(
@@ -196,10 +202,14 @@ void main() {
196202
verify(() => logger.err(errorMessage)).called(1);
197203

198204
verify(
199-
() => progress.update('Collecting licenses of 0/2 packages.'),
205+
() => progress.update(
206+
'Collecting licenses from 1 out of 2 packages',
207+
),
200208
).called(1);
201209
verify(
202-
() => progress.update('Collecting licenses of 1/2 packages.'),
210+
() => progress.update(
211+
'Collecting licenses from 2 out of 2 packages',
212+
),
203213
).called(1);
204214
verify(
205215
() => progress.complete(
@@ -241,10 +251,14 @@ void main() {
241251
verify(() => logger.err(errorMessage)).called(1);
242252

243253
verify(
244-
() => progress.update('Collecting licenses of 0/2 packages.'),
254+
() => progress.update(
255+
'Collecting licenses from 1 out of 2 packages',
256+
),
245257
).called(1);
246258
verify(
247-
() => progress.update('Collecting licenses of 1/2 packages.'),
259+
() => progress.update(
260+
'Collecting licenses from 2 out of 2 packages',
261+
),
248262
).called(1);
249263
verify(
250264
() => progress.complete(
@@ -296,10 +310,14 @@ void main() {
296310
).called(1);
297311

298312
verify(
299-
() => progress.update('Collecting licenses of 0/2 packages.'),
313+
() => progress.update(
314+
'Collecting licenses from 1 out of 2 packages',
315+
),
300316
).called(1);
301317
verify(
302-
() => progress.update('Collecting licenses of 1/2 packages.'),
318+
() => progress.update(
319+
'Collecting licenses from 2 out of 2 packages',
320+
),
303321
).called(1);
304322
verify(
305323
() => progress.complete(
@@ -382,7 +400,9 @@ void main() {
382400
);
383401

384402
verify(
385-
() => progress.update('Collecting licenses of 0/1 packages.'),
403+
() => progress.update(
404+
'Collecting licenses from 1 out of 1 package',
405+
),
386406
).called(1);
387407
verify(
388408
() => progress.complete(
@@ -431,7 +451,9 @@ void main() {
431451
);
432452

433453
verify(
434-
() => progress.update('Collecting licenses of 0/1 packages.'),
454+
() => progress.update(
455+
'Collecting licenses from 1 out of 1 package',
456+
),
435457
).called(1);
436458
verify(
437459
() => progress.complete(
@@ -481,7 +503,9 @@ void main() {
481503
);
482504

483505
verify(
484-
() => progress.update('Collecting licenses of 0/1 packages.'),
506+
() => progress.update(
507+
'Collecting licenses from 1 out of 1 package',
508+
),
485509
).called(1);
486510
verify(
487511
() => progress.complete(
@@ -530,7 +554,9 @@ void main() {
530554
);
531555

532556
verify(
533-
() => progress.update('Collecting licenses of 0/1 packages.'),
557+
() => progress.update(
558+
'Collecting licenses from 1 out of 1 package',
559+
),
534560
).called(1);
535561
verify(
536562
() => progress.complete(
@@ -583,13 +609,19 @@ void main() {
583609
);
584610

585611
verify(
586-
() => progress.update('Collecting licenses of 0/3 packages.'),
612+
() => progress.update(
613+
'Collecting licenses from 1 out of 3 packages',
614+
),
587615
).called(1);
588616
verify(
589-
() => progress.update('Collecting licenses of 1/3 packages.'),
617+
() => progress.update(
618+
'Collecting licenses from 2 out of 3 packages',
619+
),
590620
).called(1);
591621
verify(
592-
() => progress.update('Collecting licenses of 2/3 packages.'),
622+
() => progress.update(
623+
'Collecting licenses from 3 out of 3 packages',
624+
),
593625
).called(1);
594626
verify(
595627
() => progress.complete(
@@ -936,7 +968,9 @@ void main() {
936968
);
937969

938970
verify(
939-
() => progress.update('Collecting licenses of 0/1 packages.'),
971+
() => progress.update(
972+
'Collecting licenses from 1 out of 1 package',
973+
),
940974
).called(1);
941975
verify(
942976
() => progress.complete(

0 commit comments

Comments
 (0)