Skip to content

Commit b66d390

Browse files
felangelalestiago
andauthored
fix!: license check should exit 0 when no dependencies found (#1261)
* fix: license check should exit 0 when no dependencies found * chore: remove ignore: no_adjacent_strings_in_list --------- Co-authored-by: Alejandro Santiago <[email protected]>
1 parent dbd58da commit b66d390

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lib/src/commands/packages/commands/check/commands/licenses.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,10 +203,10 @@ class PackagesCheckLicensesCommand extends Command<int> {
203203

204204
if (filteredDependencies.isEmpty) {
205205
progress.cancel();
206-
_logger.err(
206+
_logger.info(
207207
'''No hosted dependencies found in $targetPath of type: ${dependencyTypes.stringify()}.''',
208208
);
209-
return ExitCode.usage.code;
209+
return ExitCode.success.code;
210210
}
211211

212212
final packageConfig = await _tryFindPackageConfig(targetDirectory);

test/src/commands/packages/commands/check/commands/licenses_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1428,13 +1428,13 @@ void main() {
14281428
],
14291429
);
14301430

1431-
final errorMessage =
1431+
final expectedMessage =
14321432
'''No hosted dependencies found in ${tempDirectory.path} of type: direct-main.''';
1433-
verify(() => logger.err(errorMessage)).called(1);
1433+
verify(() => logger.info(expectedMessage)).called(1);
14341434

14351435
verify(() => progress.cancel()).called(1);
14361436

1437-
expect(result, equals(ExitCode.usage.code));
1437+
expect(result, equals(ExitCode.success.code));
14381438
}),
14391439
);
14401440
});
@@ -1512,13 +1512,13 @@ void main() {
15121512
[...commandArguments, tempDirectory.path],
15131513
);
15141514

1515-
final errorMessage =
1515+
final expectedMessage =
15161516
'''No hosted dependencies found in ${tempDirectory.path} of type: direct-main.''';
1517-
verify(() => logger.err(errorMessage)).called(1);
1517+
verify(() => logger.info(expectedMessage)).called(1);
15181518

15191519
verify(() => progress.cancel()).called(1);
15201520

1521-
expect(result, equals(ExitCode.usage.code));
1521+
expect(result, equals(ExitCode.success.code));
15221522
}),
15231523
);
15241524

0 commit comments

Comments
 (0)