Commit da62caa
authored
fix: enhance optimizer bundle generation verification (#1451)
Fixes #1360
The previous CI verification using `git diff` could not detect new
untracked files added to the brick. This caused PR #1344 to pass CI
with a stale bundle, which was later discovered in PR #1358.
Changes:
- Replace simple `git diff` with comprehensive two-part verification
- Check for both modifications AND untracked/deleted bundle files
- Add bundle file path to workflow triggers for direct changes
- Improve error messages with clear remediation steps
The new verification now catches:
- Modified brick files (existing behavior)
- New brick files added (NEW - fixes the bug)
- Deleted brick files (existing behavior)
- Incorrect output paths (NEW)
- Direct bundle modifications (improved)
This ensures the committed bundle always matches what the current
brick source would generate, preventing silent bundle drift.1 parent a7db1d8 commit da62caa
1 file changed
+26
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
43 | | - | |
44 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
0 commit comments