Skip to content

Commit ec31ed9

Browse files
author
Jochum van der Ploeg
authored
fix: move alert messages to custom method (#461)
1 parent fc41f17 commit ec31ed9

File tree

7 files changed

+22
-7
lines changed

7 files changed

+22
-7
lines changed

lib/src/commands/create/templates/dart_package/dart_package_template.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:mason/mason.dart';
22
import 'package:universal_io/io.dart';
33
import 'package:very_good_cli/src/commands/create/templates/templates.dart';
4+
import 'package:very_good_cli/src/logger_extension.dart';
45

56
/// {@template dart_pkg_template}
67
/// A Dart package template.
@@ -24,7 +25,7 @@ class DartPkgTemplate extends Template {
2425
void _logSummary(Logger logger) {
2526
logger
2627
..info('\n')
27-
..alert('Created a Very Good Dart Package! 🦄')
28+
..created('Created a Very Good Dart Package! 🦄')
2829
..info('\n');
2930
}
3031
}

lib/src/commands/create/templates/flutter_package/flutter_package_template.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:mason/mason.dart';
22
import 'package:universal_io/io.dart';
33
import 'package:very_good_cli/src/commands/create/templates/templates.dart';
4+
import 'package:very_good_cli/src/logger_extension.dart';
45

56
/// {@template flutter_pkg_template}
67
/// A Flutter package template.
@@ -24,7 +25,7 @@ class FlutterPkgTemplate extends Template {
2425
void _logSummary(Logger logger) {
2526
logger
2627
..info('\n')
27-
..alert('Created a Very Good Flutter Package! 🦄')
28+
..created('Created a Very Good Flutter Package! 🦄')
2829
..info('\n');
2930
}
3031
}

lib/src/commands/create/templates/flutter_plugin/flutter_plugin_template.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:mason/mason.dart';
22
import 'package:universal_io/io.dart';
33
import 'package:very_good_cli/src/commands/create/templates/templates.dart';
4+
import 'package:very_good_cli/src/logger_extension.dart';
45

56
/// {@template flutter_plugin_template}
67
/// A Flutter plugin template.
@@ -24,7 +25,7 @@ class FlutterPluginTemplate extends Template {
2425
void _logSummary(Logger logger) {
2526
logger
2627
..info('\n')
27-
..alert('Created a Very Good Flutter Plugin! 🦄')
28+
..created('Created a Very Good Flutter Plugin! 🦄')
2829
..info('\n');
2930
}
3031
}

lib/src/commands/create/templates/very_good_core/very_good_core_template.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:mason/mason.dart';
22
import 'package:universal_io/io.dart';
33
import 'package:very_good_cli/src/commands/create/templates/templates.dart';
4+
import 'package:very_good_cli/src/logger_extension.dart';
45

56
/// {@template very_good_core_template}
67
/// A core Flutter app template.
@@ -24,7 +25,7 @@ class VeryGoodCoreTemplate extends Template {
2425
void _logSummary(Logger logger) {
2526
logger
2627
..info('\n')
27-
..alert('Created a Very Good App! 🦄')
28+
..created('Created a Very Good App! 🦄')
2829
..info('\n')
2930
..info(
3031
lightGray.wrap(

lib/src/commands/create/templates/very_good_dart_cli/very_good_dart_cli_template.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import 'dart:io';
22

33
import 'package:mason_logger/mason_logger.dart';
44
import 'package:very_good_cli/src/commands/create/templates/templates.dart';
5+
import 'package:very_good_cli/src/logger_extension.dart';
56

67
/// {@template dart_cli_template}
78
/// A Dart CLI application template.
@@ -25,7 +26,7 @@ class VeryGoodDartCLITemplate extends Template {
2526
void _logSummary(Logger logger) {
2627
logger
2728
..info('\n')
28-
..alert('Created a Very Good Dart CLI application! 🦄')
29+
..created('Created a Very Good Dart CLI application! 🦄')
2930
..info('\n');
3031
}
3132
}

lib/src/logger_extension.dart

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import 'package:mason_logger/mason_logger.dart';
2+
3+
/// Extension on the Logger class for custom styled logging.
4+
extension LoggerX on Logger {
5+
/// Log a message in the "created" style of the CLI.
6+
void created(String message) {
7+
info(lightCyan.wrap(styleBold.wrap(message)));
8+
}
9+
}

test/src/commands/create/create_test.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import 'package:usage/usage_io.dart';
1111
import 'package:very_good_cli/src/command_runner.dart';
1212
import 'package:very_good_cli/src/commands/create/create.dart';
1313
import 'package:very_good_cli/src/commands/create/templates/templates.dart';
14+
import 'package:very_good_cli/src/logger_extension.dart';
1415

1516
import '../../../helpers/helpers.dart';
1617

@@ -219,7 +220,7 @@ void main() {
219220
verify(
220221
() => logger.progress('Running "flutter packages get" in .tmp'),
221222
).called(1);
222-
verify(() => logger.alert('Created a Very Good App! 🦄')).called(1);
223+
verify(() => logger.created('Created a Very Good App! 🦄')).called(1);
223224
verify(
224225
() => generator.generate(
225226
any(
@@ -565,7 +566,7 @@ void main() {
565566
verify(
566567
() => logger.progress(getPackagesMsg),
567568
).called(1);
568-
verify(() => logger.alert(expectedLogSummary)).called(1);
569+
verify(() => logger.created(expectedLogSummary)).called(1);
569570
verify(
570571
() => generator.generate(
571572
any(

0 commit comments

Comments
 (0)