Merge remote-tracking branch 'origin' into feat/filter-optimization

Author: matiasleyba

.github/workflows/bump_templates.yaml

@@ -22,20 +22,13 @@ jobs:
       - name: Bump templates
         run: tool/generate_bundles.sh
 
-      - name: Config Git User
-        run: |
-          git config user.name VGV Bot
-          git config user.email [email protected]
-
       - name: Create Pull Request
         uses: peter-evans/[email protected]
         with:
+          token: ${{ secrets.VGV_BOT_PAT }}
           base: main
           branch: feat/bump-template-bundles
           commit-message: "feat: bump template bundles"
           title: "feat: bump template bundles"
           body: Please squash and merge me!
           labels: bot
-          author: VGV Bot <[email protected]>
-          assignees: vgvbot
-          committer: VGV Bot <[email protected]>

.github/workflows/e2e.yaml

@@ -21,7 +21,6 @@ on:
 jobs:
   e2e:
     runs-on: ubuntu-latest
-
     strategy:
       matrix:
         test:

.github/workflows/site.yaml

@@ -27,7 +27,7 @@ jobs:
       - name: ⚙️ Setup Node
         uses: actions/setup-node@v5
         with:
-          node-version: 18.x
+          node-version: 20.x
           cache: npm
           cache-dependency-path: site/package-lock.json
 
@@ -42,45 +42,3 @@ jobs:
 
       - name: 👷 Build website
         run: npm run build
-
-  deploy:
-    needs: build
-
-    runs-on: ubuntu-latest
-
-    if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
-
-    defaults:
-      run:
-        working-directory: site
-
-    steps:
-      - name: 📚 Git Checkout
-        uses: actions/checkout@v5
-
-      - name: ⚙️ Setup Node
-        uses: actions/setup-node@v5
-        with:
-          node-version: 18.x
-          cache: npm
-          cache-dependency-path: site/package-lock.json
-
-      - name: 📦 Install Dependencies
-        run: npm ci
-
-      - name: ✨ Check Format
-        run: npm run format:check
-
-      - name: 🧹 Lint
-        run: npm run lint
-
-      - name: 👷 Build website
-        run: npm run build
-
-      - name: ☁️ Deploy to GitHub Pages
-        uses: peaceiris/actions-gh-pages@v4
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          publish_dir: ./site/build
-          user_name: github-actions[bot]
-          user_email: 41898282+github-actions[bot]@users.noreply.github.com

.github/workflows/site_deploy.yaml

@@ -0,0 +1,46 @@
+name: site_deploy
+
+on:
+  push:
+    tags:
+      - "v[0-9]+.[0-9]+.[0-9]+*"
+  workflow_dispatch:
+  
+jobs:
+  deploy:
+    runs-on: ubuntu-latest
+
+    defaults:
+      run:
+        working-directory: site
+
+    steps:
+      - name: 📚 Git Checkout
+        uses: actions/checkout@v5
+
+      - name: ⚙️ Setup Node
+        uses: actions/setup-node@v5
+        with:
+          node-version: 18.x
+          cache: npm
+          cache-dependency-path: site/package-lock.json
+
+      - name: 📦 Install Dependencies
+        run: npm ci
+
+      - name: ✨ Check Format
+        run: npm run format:check
+
+      - name: 🧹 Lint
+        run: npm run lint
+
+      - name: 👷 Build website
+        run: npm run build
+
+      - name: ☁️ Deploy to GitHub Pages
+        uses: peaceiris/actions-gh-pages@v4
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          publish_dir: ./site/build
+          user_name: github-actions[bot]
+          user_email: 41898282+github-actions[bot]@users.noreply.github.com

.github/workflows/spdx_license_bot.yaml

@@ -37,12 +37,6 @@ jobs:
         id: make
         run: if [[ $(mason make spdx_license -q --licenses "[]" -o test --on-conflict overwrite --set-exit-if-changed) =~ "0 files changed" ]]; then echo "did_change=false"; else echo "did_change=true"; fi >> $GITHUB_ENV
 
-      - name: 🔑 Config Git User
-        if: ${{ env.did_change == 'true' }}
-        run: |
-          git config user.name VGV Bot
-          git config user.email [email protected]
-
       - name: 🧱 Mason Make (lib/pub_license/spdx_license)
         if: ${{ env.did_change == 'true' }}
         run: |
@@ -55,12 +49,10 @@ jobs:
         if: ${{ env.did_change == 'true' }}
         uses: peter-evans/[email protected]
         with:
+          token: ${{ secrets.VGV_BOT_PAT }}
           base: main
           branch: chore/update-spdx-license
           commit-message: "chore: update SPDX licenses"
           title: "chore: update SPDX licenses"
           body: Please squash and merge me!
           labels: bot
-          author: VGV Bot <[email protected]>
-          assignees: vgvbot
-          committer: VGV Bot <[email protected]>

bricks/test_optimizer/hooks/lib/pre_gen.dart

@@ -1,6 +1,3 @@
-// No need for documentation in brick hooks
-// ignore_for_file: public_member_api_docs
-
 import 'dart:io';
 
 import 'package:hooks/dart_identifier_generator.dart';

bricks/test_optimizer/hooks/pubspec.yaml

@@ -13,4 +13,4 @@ dependencies:
 dev_dependencies:
   mocktail: ^1.0.0
   test: ^1.25.0
-  very_good_analysis: ^9.0.0
+  very_good_analysis: ^10.0.0

e2e/pubspec.yaml

@@ -13,6 +13,6 @@ dev_dependencies:
   pub_updater: ^0.5.0
   test: ^1.25.0
   universal_io: ^2.0.4
-  very_good_analysis: ^9.0.0
+  very_good_analysis: ^10.0.0
   very_good_cli:
     path: ../

e2e/test/commands/create/dart_cli/dart_cli_test.dart

@@ -64,7 +64,7 @@ void main() {
         ['coverage/lcov.info', '-o', 'coverage'],
         workingDirectory: workingDirectory,
       );
-      expect(testCoverageResult.stdout, contains('lines......: 100.0%'));
+      expect(testCoverageResult.stdout, matches(RegExp('lines(.+) 100.0%')));
     }),
   );
 }

e2e/test/commands/create/dart_package/dart_pkg_test.dart

@@ -65,7 +65,7 @@ void main() {
         ['coverage/lcov.info', '-o', 'coverage'],
         workingDirectory: workingDirectory,
       );
-      expect(testCoverageResult.stdout, contains('lines......: 100.0%'));
+      expect(testCoverageResult.stdout, matches(RegExp('lines(.+) 100.0%')));
     }),
   );
 }