Skip to content
This repository was archived by the owner on Feb 21, 2024. It is now read-only.

Commit c839bf5

Browse files
authored
chore: bump Dart SDK to >=3.0.0 <4.0.0 (#101)
* chore: bump Dart SDK to >=3.0.0 <4.0.0 * fix: Replace 0 to ExitCode.success.code
1 parent 44c6c44 commit c839bf5

File tree

5 files changed

+21
-28
lines changed

5 files changed

+21
-28
lines changed

src/my_cli/analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include: package:very_good_analysis/analysis_options.4.0.0.yaml
1+
include: package:very_good_analysis/analysis_options.yaml
22
linter:
33
rules:
44
public_member_api_docs: false

src/my_cli/pubspec.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@ version: 0.0.1
44
publish_to: none
55

66
environment:
7-
sdk: ">=2.19.0 <3.0.0"
7+
sdk: ">=3.0.0 <4.0.0"
88

99
dependencies:
10-
args: ^2.3.1
10+
args: ^2.4.1
1111
cli_completion: ^0.3.0
12-
mason_logger: ^0.2.4
12+
mason_logger: ^0.2.5
1313
pub_updater: ^0.3.0
1414

1515
dev_dependencies:
16-
build_runner: ^2.0.0
17-
build_verify: ^3.0.0
18-
build_version: ^2.0.0
16+
build_runner: ^2.4.4
17+
build_verify: ^3.1.0
18+
build_version: ^2.1.1
1919
mocktail: ^0.3.0
20-
test: ^1.19.2
21-
very_good_analysis: ^4.0.0
20+
test: ^1.24.2
21+
very_good_analysis: ^4.0.0+1
2222

2323
executables:
2424
my_executable:

src/my_cli/test/src/command_runner_test.dart

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ import 'package:test/test.dart';
1111

1212
class _MockLogger extends Mock implements Logger {}
1313

14-
class _MockProcessResult extends Mock implements ProcessResult {}
15-
1614
class _MockProgress extends Mock implements Progress {}
1715

1816
class _MockPubUpdater extends Mock implements PubUpdater {}
@@ -27,7 +25,6 @@ void main() {
2725
group('MyCLICommandRunner', () {
2826
late PubUpdater pubUpdater;
2927
late Logger logger;
30-
late ProcessResult processResult;
3128
late MyCLICommandRunner commandRunner;
3229

3330
setUp(() {
@@ -39,9 +36,6 @@ void main() {
3936

4037
logger = _MockLogger();
4138

42-
processResult = _MockProcessResult();
43-
when(() => processResult.exitCode).thenReturn(ExitCode.success.code);
44-
4539
commandRunner = MyCLICommandRunner(
4640
logger: logger,
4741
pubUpdater: pubUpdater,
@@ -81,7 +75,9 @@ void main() {
8175
packageName: packageName,
8276
versionConstraint: any(named: 'versionConstraint'),
8377
),
84-
).thenAnswer((_) async => processResult);
78+
).thenAnswer(
79+
(_) async => ProcessResult(0, ExitCode.success.code, null, null),
80+
);
8581
when(
8682
() => pubUpdater.isUpToDate(
8783
packageName: any(named: 'packageName'),

src/my_cli/test/src/commands/update_command_test.dart

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ import 'package:test/test.dart';
1010

1111
class _MockLogger extends Mock implements Logger {}
1212

13-
class _MockProcessResult extends Mock implements ProcessResult {}
14-
1513
class _MockProgress extends Mock implements Progress {}
1614

1715
class _MockPubUpdater extends Mock implements PubUpdater {}
@@ -22,15 +20,13 @@ void main() {
2220
group('update', () {
2321
late PubUpdater pubUpdater;
2422
late Logger logger;
25-
late ProcessResult processResult;
2623
late MyCLICommandRunner commandRunner;
2724

2825
setUp(() {
2926
final progress = _MockProgress();
3027
final progressLogs = <String>[];
3128
pubUpdater = _MockPubUpdater();
3229
logger = _MockLogger();
33-
processResult = _MockProcessResult();
3430
commandRunner = MyCLICommandRunner(
3531
logger: logger,
3632
pubUpdater: pubUpdater,
@@ -44,7 +40,9 @@ void main() {
4440
packageName: packageName,
4541
versionConstraint: latestVersion,
4642
),
47-
).thenAnswer((_) async => processResult);
43+
).thenAnswer(
44+
(_) async => ProcessResult(0, ExitCode.success.code, null, null),
45+
);
4846
when(
4947
() => pubUpdater.isUpToDate(
5048
packageName: any(named: 'packageName'),
@@ -56,7 +54,6 @@ void main() {
5654
if (message != null) progressLogs.add(message);
5755
});
5856
when(() => logger.progress(any())).thenReturn(progress);
59-
when(() => processResult.exitCode).thenReturn(ExitCode.success.code);
6057
});
6158

6259
test('can be instantiated without a pub updater', () {
@@ -111,8 +108,6 @@ void main() {
111108
test('handles pub update process errors', () async {
112109
const error = 'Oh no! Installing this is not possible right now!';
113110

114-
when(() => processResult.exitCode).thenReturn(1);
115-
when<dynamic>(() => processResult.stderr).thenReturn(error);
116111
when(
117112
() => pubUpdater.getLatestVersion(any()),
118113
).thenAnswer((_) async => latestVersion);
@@ -122,7 +117,7 @@ void main() {
122117
packageName: any(named: 'packageName'),
123118
versionConstraint: any(named: 'versionConstraint'),
124119
),
125-
).thenAnswer((_) async => processResult);
120+
).thenAnswer((_) async => ProcessResult(0, 1, null, error));
126121

127122
final result = await commandRunner.run(['update']);
128123

@@ -148,7 +143,9 @@ void main() {
148143
packageName: any(named: 'packageName'),
149144
versionConstraint: any(named: 'versionConstraint'),
150145
),
151-
).thenAnswer((_) async => processResult);
146+
).thenAnswer(
147+
(_) async => ProcessResult(0, ExitCode.success.code, null, null),
148+
);
152149
when(() => logger.progress(any())).thenReturn(_MockProgress());
153150
final result = await commandRunner.run(['update']);
154151
expect(result, equals(ExitCode.success.code));

tool/generator/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: generator
22
description: A template generator for Very Good Dart CLI.
33

44
environment:
5-
sdk: ">=2.17.0 <3.0.0"
5+
sdk: ">=3.0.0 <4.0.0"
66

77
dependencies:
8-
path: ^1.8.0
8+
path: ^1.8.3

0 commit comments

Comments
 (0)