fix: remove conditional logic from Playwright tests for consistent CI behavior

- Playwright webServer always runs in production mode (npm run build && npm run start)
- Removed NODE_ENV checks that caused CI failures
- Tests now always expect production behavior (redirect to homepage, 403 responses)
- All 17 tests passing consistently in both local and CI environments

Author: jeromehardaway

tests/security/auth-protection.spec.ts

@@ -87,49 +87,29 @@ test.describe('Protected Routes - Authentication Required', () => {
 test.describe('Dev Login Protection', () => {
 
   test('Dev login page should not be accessible in production', async ({ page }) => {
-    // This test assumes NODE_ENV=production
+    // Playwright webServer runs in production mode (npm run build && npm run start)
     // In production, /dev-login should redirect to homepage
 
-    // Note: This test needs to be run with NODE_ENV=production
-    // In development, it will show the dev login page (expected behavior)
+    await page.goto('/dev-login');
 
-    const response = await page.goto('/dev-login');
-
-    // Check if we're in production mode by checking environment
-    // If in production, should redirect to home
-    // If in development, should show dev login page
-
-    const isProduction = process.env.NODE_ENV === 'production';
-
-    if (isProduction) {
-      // Should redirect to homepage in production
-      expect(page.url()).toBe(new URL('/', page.url()).href);
-    } else {
-      // In development, should show dev login page
-      expect(response?.status()).toBe(200);
-      await expect(page.locator('h1')).toContainText('Development Login');
-    }
+    // Should redirect to homepage in production
+    expect(page.url()).toBe(new URL('/', page.url()).href);
   });
 
   test('Dev session API should return 403 in production', async ({ request }) => {
-    // This test verifies the API endpoint protection
-    const isProduction = process.env.NODE_ENV === 'production';
+    // Playwright webServer runs in production mode (npm run build && npm run start)
+    // Dev session API should return 403 in production
 
     const response = await request.post('/api/auth/dev-session', {
       data: {
         email: '[email protected]'
       }
     });
 
-    if (isProduction) {
-      // Should return 403 in production
-      expect(response.status()).toBe(403);
-      const data = await response.json();
-      expect(data.error).toBe('Not available in production');
-    } else {
-      // In development, should work
-      expect(response.status()).toBeLessThan(500);
-    }
+    // Should return 403 in production
+    expect(response.status()).toBe(403);
+    const data = await response.json();
+    expect(data.error).toBe('Not available in production');
   });
 });