Null check chest dialog storage in ChestDialogViewProvider#closeDialog (#1097)

FlorianMichael · web-flow · commit 6ad05d8bc2ea · 2025-09-12T21:14:54.000+02:00
diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
@@ -120,6 +120,9 @@ public void closeDialog(final UserConnection connection) {
         }
 
         final ChestDialogStorage storage = connection.get(ChestDialogStorage.class);
+        if (storage == null) {
+            return;
+        }
 
         final PacketWrapper containerClose = PacketWrapper.create(ClientboundPackets1_21_5.CONTAINER_CLOSE, connection);
         containerClose.write(Types.VAR_INT, storage.containerId());

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,9 @@ public void closeDialog(final UserConnection connection) {`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`final ChestDialogStorage storage = connection.get(ChestDialogStorage.class);`
	`123`	`+ if (storage == null) {`
	`124`	`+ return;`
	`125`	`+ }`
`123`	`126`
`124`	`127`	`final PacketWrapper containerClose = PacketWrapper.create(ClientboundPackets1_21_5.CONTAINER_CLOSE, connection);`
`125`	`128`	`containerClose.write(Types.VAR_INT, storage.containerId());`