Copy over always show nametag 1:1

Author: florianreuth

common/build.gradle.kts

@@ -10,7 +10,7 @@ dependencies {
     compileOnly("io.netty:netty-all:4.0.20.Final")
     compileOnly("com.google.guava:guava:17.0")
 
-    viaProxy("net.raphimc:ViaProxy:3.4.2-SNAPSHOT") {
+    viaProxy("net.raphimc:ViaProxy:3.4.4-SNAPSHOT") {
         isTransitive = false
     }
 }

common/src/main/java/com/viaversion/viarewind/protocol/v1_8to1_7_6_10/data/VirtualHologramEntity.java

@@ -48,7 +48,7 @@ public class VirtualHologramEntity {
     private float headYaw;
     private boolean small = false;
     private boolean marker = false;
-    private boolean showNametag = false;
+    private byte alwaysShowNametag;
 
     public VirtualHologramEntity(final UserConnection user, final int entityId) {
         this.user = user;
@@ -99,23 +99,21 @@ public void syncState(final EntityPacketRewriter1_8 entityRewriter, final List<E
         // Filter armor stand data to calculate emulation
         byte flags = 0;
         byte armorStandFlags = 0;
-        byte nameTagFlags = 0;
         for (EntityData entityData : entityDataTracker) {
             if (entityData.id() == 0 && entityData.dataType() == EntityDataTypes1_8.BYTE) {
                 flags = ((Number) entityData.getValue()).byteValue();
             } else if (entityData.id() == 2 && entityData.dataType() == EntityDataTypes1_8.STRING) {
                 name = entityData.getValue().toString();
                 if (name != null && name.isEmpty()) name = null;
+            } else if (entityData.id() == 3 && entityData.dataType() == EntityDataTypes1_8.BYTE) {
+                alwaysShowNametag = ((Number) entityData.getValue()).byteValue();
             } else if (entityData.id() == 10 && entityData.dataType() == EntityDataTypes1_8.BYTE) {
                 armorStandFlags = ((Number) entityData.getValue()).byteValue();
-            } else if (entityData.id() == 3 && entityData.dataType() == EntityDataTypes1_8.BYTE) {
-                nameTagFlags = ((Number) entityData.getValue()).byteValue();
             }
         }
         final boolean invisible = (flags & 0x20) != 0;
         small = (armorStandFlags & 0x01) != 0;
         marker = (armorStandFlags & 0x10) != 0;
-        showNametag = (nameTagFlags & 0x01) != 0;
 
         State prevState = currentState;
         if (invisible && name != null) {
@@ -258,7 +256,7 @@ private void writeHologramMeta(PacketWrapper wrapper) {
         final List<EntityData> entityDataList = new ArrayList<>();
         entityDataList.add(new EntityData(EntityDataIndex1_7_6_10.ABSTRACT_AGEABLE_AGE.getIndex(), EntityDataTypes1_7_6_10.INT, -1700000));
         entityDataList.add(new EntityData(EntityDataIndex1_7_6_10.LIVING_ENTITY_BASE_NAME_TAG.getIndex(), EntityDataTypes1_7_6_10.STRING, name));
-        entityDataList.add(new EntityData(EntityDataIndex1_7_6_10.LIVING_ENTITY_BASE_NAME_TAG_VISIBILITY.getIndex(), EntityDataTypes1_7_6_10.BYTE, (byte) (showNametag ? 1 : 0)));
+        entityDataList.add(new EntityData(EntityDataIndex1_7_6_10.LIVING_ENTITY_BASE_NAME_TAG_VISIBILITY.getIndex(), EntityDataTypes1_7_6_10.BYTE, alwaysShowNametag));
 
         wrapper.write(RewindTypes.ENTITY_DATA_LIST1_7, entityDataList);
     }