WritePrometheus: reduce metricType() calls.

makasim · makasim · commit 5fb241fecf07 · 2025-09-12T12:32:14.000+03:00
diff --git a/set.go b/set.go
@@ -47,9 +47,12 @@ func (s *Set) WritePrometheus(w io.Writer) {
 			return fName1 < fName2
 		}
 
+		mType1 := s.a[i].metric.metricType()
+		mType2 := s.a[j].metric.metricType()
+
 		// stabilize the order for summary and quantiles.
-		if s.a[i].metric.metricType() != s.a[j].metric.metricType() {
-			return s.a[i].metric.metricType() < s.a[j].metric.metricType()
+		if mType1 != mType2 {
+			return mType1 < mType2
 		}
 
 		// lastly by metric names, which is for quantiles and histogram buckets.

Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,12 @@ func (s *Set) WritePrometheus(w io.Writer) {`
`47`	`47`	`return fName1 < fName2`
`48`	`48`	`}`
`49`	`49`
	`50`	`+ mType1 := s.a[i].metric.metricType()`
	`51`	`+ mType2 := s.a[j].metric.metricType()`
	`52`	`+`
`50`	`53`	`// stabilize the order for summary and quantiles.`
`51`		`- if s.a[i].metric.metricType() != s.a[j].metric.metricType() {`
`52`		`- return s.a[i].metric.metricType() < s.a[j].metric.metricType()`
	`54`	`+ if mType1 != mType2 {`
	`55`	`+ return mType1 < mType2`
`53`	`56`	`}`
`54`	`57`
`55`	`58`	`// lastly by metric names, which is for quantiles and histogram buckets.`