Skip to content

Commit 014d723

Browse files
authored
clarify deprecation plan for use_deprecated_instrumentation_name (#2254)
* clarify deprecation plan * update allocations
1 parent 68b7f7c commit 014d723

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

docs/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ nav_order: 6
1414

1515
*Joel Hawksley*
1616

17+
* Clarify that `config.use_deprecated_instrumentation_name` will be removed in v4.
18+
19+
*Joel Hawksley*
20+
1721
## 3.22.0
1822

1923
* Rewrite `ViewComponents at GitHub` documentation as more general `Best practices`.

docs/api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ Defaults to `ApplicationController`.
269269

270270
Whether ActiveSupport Notifications use the private name `"!render.view_component"`
271271
or are made more publicly available via `"render.view_component"`.
272-
Will default to `false` in next major version.
272+
Will be removed in next major version.
273273
Defaults to `true`.
274274

275275
### `.view_component_path`

lib/view_component/config.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def defaults
123123
# @return [Boolean]
124124
# Whether ActiveSupport Notifications use the private name `"!render.view_component"`
125125
# or are made more publicly available via `"render.view_component"`.
126-
# Will default to `false` in next major version.
126+
# Will be removed in next major version.
127127
# Defaults to `true`.
128128

129129
# @!attribute render_monkey_patch_enabled

test/sandbox/test/rendering_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def test_render_inline_allocations
1616
MyComponent.ensure_compiled
1717

1818
allocations = (Rails.version.to_f >= 8.0) ?
19-
{"3.5.0" => 121, "3.4.2" => 125, "3.3.7" => 137} :
19+
{"3.5.0" => 119, "3.4.2" => 125, "3.3.7" => 137} :
2020
{"3.3.7" => 128, "3.3.0" => 140, "3.2.8" => 126, "3.1.7" => 126, "3.0.7" => 135}
2121

2222
assert_allocations(**allocations) do

0 commit comments

Comments
 (0)