Skip to content

Commit 33aec2e

Browse files
authored
Merge pull request #2377 from ViewComponent/alert-autofix-14
Potential fix for code scanning alert no. 14: Incomplete regular expression for hostnames
2 parents 1e965b1 + b69b7b5 commit 33aec2e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/sandbox/test/rendering_test.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -372,18 +372,18 @@ def test_renders_component_without_format
372372

373373
def test_renders_component_with_asset_url
374374
component = AssetComponent.new
375-
assert_match(%r{http://assets.example.com/assets/application-\w+.css}, render_inline(component).text)
375+
assert_match(%r{http://assets\.example\.com/assets/application-\w+\.css}, render_inline(component).text)
376376

377377
if Rails.version.to_f < 8.0
378378
# Propshaft doesn't allow setting custom hosts so this only works in Rails < 8
379379
component.config.asset_host = nil
380-
assert_match(%r{/assets/application-\w+.css}, render_inline(component).text)
380+
assert_match(%r{/assets/application-\w+\.css}, render_inline(component).text)
381381

382382
component.config.asset_host = "http://assets.example.com"
383-
assert_match(%r{http://assets.example.com/assets/application-\w+.css}, render_inline(component).text)
383+
assert_match(%r{http://assets\.example\.com/assets/application-\w+\.css}, render_inline(component).text)
384384

385385
component.config.asset_host = "assets.example.com"
386-
assert_match(%r{http://assets.example.com/assets/application-\w+.css}, render_inline(component).text)
386+
assert_match(%r{http://assets\.example\.com/assets/application-\w+\.css}, render_inline(component).text)
387387
end
388388
end
389389

0 commit comments

Comments
 (0)