Clarify error message about render-dependent logic (#2217)

* Clarify error message about render-dependent logic

* changelog

Author: joelhawksley

docs/CHANGELOG.md

@@ -14,6 +14,12 @@ nav_order: 5
 
     *Kane Jamison*
 
+* Clarify error message about render-dependent logic.
+
+  Error messages about render-dependent logic were sometimes inaccurate, saying `during initialization` despite also being raised after a component had been initialized but before it was rendered.
+
+    *Joel Hawksley*
+
 * Remove JS and CSS docs as they proved difficult to maintain and lacked consensus.
 
     *Joel Hawksley*

lib/view_component/errors.rb

@@ -177,7 +177,7 @@ class NilWithContentError < BaseError
 
   class TranslateCalledBeforeRenderError < BaseError
     MESSAGE =
-      "`#translate` can't be used during initialization as it depends " \
+      "`#translate` can't be used before rendering as it depends " \
       "on the view context that only exists once a ViewComponent is passed to " \
       "the Rails render pipeline.\n\n" \
       "It's sometimes possible to fix this issue by moving code dependent on " \
@@ -186,7 +186,7 @@ class TranslateCalledBeforeRenderError < BaseError
 
   class HelpersCalledBeforeRenderError < BaseError
     MESSAGE =
-      "`#helpers` can't be used during initialization as it depends " \
+      "`#helpers` can't be used before rendering as it depends " \
       "on the view context that only exists once a ViewComponent is passed to " \
       "the Rails render pipeline.\n\n" \
       "It's sometimes possible to fix this issue by moving code dependent on " \
@@ -195,7 +195,7 @@ class HelpersCalledBeforeRenderError < BaseError
 
   class ControllerCalledBeforeRenderError < BaseError
     MESSAGE =
-      "`#controller` can't be used during initialization, as it depends " \
+      "`#controller` can't be used before rendering, as it depends " \
       "on the view context that only exists once a ViewComponent is passed to " \
       "the Rails render pipeline.\n\n" \
       "It's sometimes possible to fix this issue by moving code dependent on " \

test/sandbox/test/base_test.rb

@@ -43,7 +43,7 @@ def test_calling_helpers_outside_render_raises
       assert_raises ViewComponent::HelpersCalledBeforeRenderError do
         component.helpers
       end
-    assert_includes err.message, "can't be used during initialization"
+    assert_includes err.message, "can't be used before rendering"
   end
 
   def test_calling_controller_outside_render_raises
@@ -53,7 +53,7 @@ def test_calling_controller_outside_render_raises
         component.controller
       end
 
-    assert_includes err.message, "can't be used during initialization"
+    assert_includes err.message, "can't be used before rendering"
   end
 
   def test_sidecar_files

test/sandbox/test/rendering_test.rb

@@ -394,7 +394,7 @@ def test_renders_component_with_initializer_translations
       assert_raises ViewComponent::TranslateCalledBeforeRenderError do
         render_inline(InitializerTranslationsComponent.new)
       end
-    assert_includes err.message, "can't be used during initialization"
+    assert_includes err.message, "can't be used before rendering"
   end
 
   def test_renders_component_with_rb_in_its_name