Skip to content

Commit 4d9d333

Browse files
authored
Merge pull request #2418 from ViewComponent/2417-changelog
Update changelog to fix incorrect items regarding generators
2 parents 33ecec7 + 2a6e8ab commit 4d9d333

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

docs/CHANGELOG.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,10 @@ Please report any issues at [https://github.com/ViewComponent/view_component/iss
4141

4242
### Breaking changes (dev/test)
4343

44-
* Rename `config.generate.component_parent_class` to `config.generate.parent_class`.
45-
* Remove `config.test_controller` in favor of `vc_test_controller_class` test helper method.
46-
* `config.component_parent_class` is now `config.generate.component_parent_class`, moving the generator-specific option to the generator configuration namespace.
44+
* Remove `config.view_component.test_controller` in favor of `vc_test_controller_class` test helper method.
45+
* `config.view_component.component_parent_class` is now `config.view_component.generate.parent_class`, moving the generator-specific option to the generator configuration namespace.
46+
* `config.view_component.view_component_path` is now `config.view_component.generate.path`, as components have long since been able to exist in any directory.
4747
* Move previews-related configuration (`enabled`, `route`, `paths`, `default_layout`, `controller`) to under `previews` namespace.
48-
* `config.view_component_path` is now `config.generate.path`, as components have long since been able to exist in any directory.
4948
* `--inline` generator option now generates inline template. Use `--call` to generate `#call` method.
5049
* Remove broken integration with `rails stats` that ignored components outside of `app/components`.
5150
* Remove `preview_source` functionality. Consider using [Lookbook](https://lookbook.build/) instead.
@@ -70,7 +69,7 @@ Please report any issues at [https://github.com/ViewComponent/view_component/iss
7069
### Bug fixes
7170

7271
* Fix bug where virtual path wasn't reset, breaking translations outside of components.
73-
* Fix bug where `config.previews.enabled` didn't function properly in production environments.
72+
* Fix bug where `config.view_component.previews.enabled` didn't function properly in production environments.
7473
* Fix bug in `SlotableDefault` where default couldn't be overridden when content was passed as a block.
7574
* Fix bug where request-aware helpers didn't work outside of the request context.
7675
* `ViewComponentsSystemTestController` shouldn't be useable outside of test environment
@@ -85,7 +84,7 @@ Please report any issues at [https://github.com/ViewComponent/view_component/iss
8584
* Update documentation on performance to reflect more representative benchmark showing 2-3x speed increase over partials.
8685
* Add documentation note about instrumentation negatively affecting performance.
8786
* Remove unnecessary ENABLE_RELOADING test suite flag.
88-
* `config.previews.default_layout` should default to nil.
87+
* `config.view_component.previews.default_layout` should default to nil.
8988
* Add test coverage for uncovered code.
9089
* Test against `turbo-rails` `v2` and `rspec-rails` `v7`.
9190

0 commit comments

Comments
 (0)