Skip to content

Commit 55306bc

Browse files
Add support for Rails 7.2 !!!!!! (#2073)
* Add support for Rails 7.2 * Apply suggestions from code review * Update docs/CHANGELOG.md * Update .github/workflows/ci.yml * Apply suggestions from code review --------- Co-authored-by: Joel Hawksley <[email protected]> Co-authored-by: Joel Hawksley <[email protected]>
1 parent e50ad2c commit 55306bc

File tree

4 files changed

+40
-16
lines changed

4 files changed

+40
-16
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
bundle exec rake partial_benchmark
2727
bundle exec rake translatable_benchmark
2828
test:
29-
name: test (${{ matrix.rails_version }}, ${{ matrix.ruby_version }}, ${{ matrix.mode }}, yjit-${{matrix.yjit_mode}})
29+
name: test (${{ matrix.rails_version }}, ${{ matrix.ruby_version }}, ${{ matrix.mode }})
3030
runs-on: ubuntu-latest
3131
strategy:
3232
fail-fast: false
@@ -35,43 +35,33 @@ jobs:
3535
- ruby_version: "3.0"
3636
rails_version: "6.1"
3737
mode: "capture_patch_enabled"
38-
yjit_mode: '0'
3938
- ruby_version: "3.0"
4039
rails_version: "6.1"
4140
mode: "capture_patch_disabled"
42-
yjit_mode: '0'
4341
- ruby_version: "3.1"
4442
rails_version: "7.0"
4543
mode: "capture_patch_enabled"
46-
yjit_mode: '1'
4744
- ruby_version: "3.1"
4845
rails_version: "7.0"
4946
mode: "capture_patch_disabled"
50-
yjit_mode: '0'
5147
- ruby_version: "3.2"
5248
rails_version: "7.1"
5349
mode: "capture_patch_enabled"
54-
yjit_mode: '0'
5550
- ruby_version: "3.2"
5651
rails_version: "7.1"
5752
mode: "capture_patch_disabled"
58-
yjit_mode: '1'
5953
- ruby_version: "3.3"
60-
rails_version: "7.1"
61-
mode: "capture_patch_enabled"
62-
yjit_mode: '1'
63-
- ruby_version: "3.3"
64-
rails_version: "7.1"
54+
rails_version: "7.2"
6555
mode: "capture_patch_disabled"
66-
yjit_mode: '1'
56+
- ruby_version: "3.3"
57+
rails_version: "7.2"
58+
mode: "capture_patch_enabled"
6759
- ruby_version: "head"
6860
rails_version: "main"
6961
mode: "capture_patch_disabled"
70-
yjit_mode: '1'
7162
- ruby_version: "head"
7263
rails_version: "main"
7364
mode: "capture_patch_enabled"
74-
yjit_mode: '1'
7565
env:
7666
BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.rails_version }}.gemfile
7767
steps:
@@ -92,7 +82,6 @@ jobs:
9282
RAISE_ON_WARNING: 1
9383
RAILS_VERSION: ${{ matrix.rails_version }}
9484
CAPTURE_PATCH_ENABLED: ${{ matrix.mode == 'capture_patch_enabled' && 'true' || 'false' }}
95-
RUBY_YJIT_ENABLE: ${{matrix.yjit_mode}}
9685
- name: Upload coverage results
9786
uses: actions/[email protected]
9887
if: always()

Appraisals

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ appraise "rails-7.1" do
2020
gem "tailwindcss-rails", "~> 2.0"
2121
end
2222

23+
appraise "rails-7.2" do
24+
gem "rails", "~> 7.2"
25+
gem "tailwindcss-rails", "~> 2.0"
26+
end
27+
2328
appraise "rails-main" do
2429
gem "rails", github: "rails/rails", branch: "main"
2530
gem "tailwindcss-rails", "~> 2.0"

docs/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ nav_order: 5
3030

3131
*Reegan Viljoen*
3232

33+
* Add support for Rails 7.2.
34+
35+
*Reegan Viljoen*
36+
3337
## 3.13.0
3438

3539
* Add ruby head and YJIT to CI.

gemfiles/rails_7.2.gemfile

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# This file was generated by Appraisal
2+
3+
source "https://rubygems.org"
4+
5+
gem "capybara", "~> 3"
6+
gem "rails", "~> 7.2"
7+
gem "rspec-rails", "~> 5"
8+
gem "net-imap", require: false
9+
gem "net-pop", require: false
10+
gem "net-smtp", require: false
11+
gem "debug"
12+
13+
gem "tailwindcss-rails", "~> 2.0"
14+
15+
group :test do
16+
gem "cuprite", "~> 0.15"
17+
gem "puma", "~> 6"
18+
gem "warning"
19+
gem "selenium-webdriver", "4.9.0"
20+
end
21+
22+
group :development, :test do
23+
gem "appraisal", "~> 2.5"
24+
end
25+
26+
gemspec path: "../"

0 commit comments

Comments
 (0)