yeah I know it aint working, I am tired however, taking a nother look tomorow

Author: reeganviljoen

lib/view_component/base.rb

@@ -45,21 +45,13 @@ def config
     delegate :content_security_policy_nonce, to: :helpers
 
     # Config option that strips trailing whitespace in templates before compiling them.
+    class_attribute :__vc_cache_dependencies, instance_accessor: false, instance_predicate: false, default: []
     class_attribute :__vc_strip_trailing_whitespace, instance_accessor: false, instance_predicate: false
     self.__vc_strip_trailing_whitespace = false # class_attribute:default doesn't work until Rails 5.2
 
     attr_accessor :__vc_original_view_context
 
-    # Compoents can have a cache key that is used to cache the rendered output.
-    #
-    # @return [String]
-    def cache_key
-      @vc_cache_key = if defined?(__vc_cache_args)
-        Digest::MD5.hexdigest(
-          __vc_cache_args.map { |method| send(method) }.join("-")
-        )
-      end
-    end
+
 
     # Components render in their own view context. Helpers and other functionality
     # require a reference to the original Rails view context, an instance of
@@ -121,8 +113,8 @@ def render_in(view_context, &block)
       if render?
         rendered_template = render_template_for(@__vc_variant, __vc_request&.format&.to_sym).to_s
 
-        if cache_key.present?
-          Rails.cache.fetch(@vc_cache_key) do
+        if view_cache_dependencies.present?
+          Rails.cache.fetch(view_cache_dependencies) do
             __vc_render_template(rendered_template)
           end
         else
@@ -276,9 +268,11 @@ def virtual_path
     # For caching, such as #cache_if
     # @private
     def view_cache_dependencies
-      []
+      self.class.view_cache_dependencies
     end
 
+    alias_method :component_cache_dependencies, :view_cache_dependencies
+
     # For caching, such as #cache_if
     #
     # @private
@@ -520,12 +514,16 @@ def sidecar_files(extensions)
         (sidecar_files - [identifier] + sidecar_directory_files + nested_component_files).uniq
       end
 
+
+
       def cache_on(*args)
-        class_eval <<~RUBY, __FILE__, __LINE__ + 1
-          def __vc_cache_args
-            #{args}
-          end
-        RUBY
+        self.__vc_cache_dependencies.push(*args)
+      end
+
+      def view_cache_dependencies
+        return unless __vc_cache_dependencies.any?
+
+        __vc_cache_dependencies.map { |dep| send(dep) }.compact
       end
 
       # Render a component for each element in a collection ([documentation](/guide/collections)):

test/sandbox/app/components/cache_component.html.erb

@@ -1,2 +1,2 @@
-<p class='cache-component__cache-key'><%= cache_key %></p>
+<p class='cache-component__cache-key'><%= view_cache_dependencies %></p>
 <p class='cache-component__cache-message'><%= "#{foo} #{bar}" %></p>

test/sandbox/test/rendering_test.rb

@@ -1245,16 +1245,16 @@ def test_cache_component
     component = CacheComponent.new(foo: "foo", bar: "bar")
     render_inline(component)
 
-    assert_selector(".cache-component__cache-key", text: component.cache_key)
+    assert_selector(".cache-component__cache-key", text: component.component_cache_dependencies)
     assert_selector(".cache-component__cache-message", text: "foo bar")
 
     render_inline(CacheComponent.new(foo: "foo", bar: "bar"))
 
-    assert_selector(".cache-component__cache-key", text: component.cache_key)
+    assert_selector(".cache-component__cache-key", text: component.component_cache_dependencies)
 
     render_inline(CacheComponent.new(foo: "foo", bar: "baz"))
 
-    refute_selector(".cache-component__cache-key", text: component.cache_key)
+    refute_selector(".cache-component__cache-key", text: component.component_cache_dependencies)
     refute_selector(".cache-component__cache-message", text: "foo bar")
   end
 end