Skip to content

Commit 66ee8ad

Browse files
committed
vale
1 parent ae97b00 commit 66ee8ad

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

docs/CHANGELOG.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ Please report any issues at [https://github.com/ViewComponent/view_component/iss
3030
* Rename internal methods to have `__vc_` prefix if they shouldn't be used by consumers. Make internal constants private. Make `Collection#components`, `Slotable#register_polymorphic_slot` private. Remove unused `ComponentError` class.
3131
* Use ActionView's `lookup_context` for picking templates instead of the request format.
3232

33-
3.15 added support for using templates that match the request format, i.e. if `/resource.csv` is requested then
33+
3.15 added support for using templates that match the request format, that is if `/resource.csv` is requested then
3434
ViewComponents would pick `_component.csv.erb` over `_component.html.erb`.
3535

36-
With this release, the request format is no longer considered and instead ViewComponent will use the Rails logic for picking the most appropriate template type, i.e. the csv template will be used if it matches the `Accept` header or because the controller uses a `respond_to` block to pick the response format.
36+
With this release, the request format is no longer considered and instead ViewComponent will use the Rails logic for picking the most appropriate template type, that is the csv template will be used if it matches the `Accept` header or because the controller uses a `respond_to` block to pick the response format.
3737

3838
### Breaking changes (dev/test)
3939

@@ -65,11 +65,11 @@ Please report any issues at [https://github.com/ViewComponent/view_component/iss
6565
### Bug fixes
6666

6767
* Fix bug where virtual path wasn't reset, breaking translations outside of components.
68-
* Fix bug where `config.previews.enabled` did not function properly in production environments.
68+
* Fix bug where `config.previews.enabled` didn't function properly in production environments.
6969
* Fix bug where response format wasn't set, which caused issues with Turbo Frames.
7070
* Fix bug in `SlotableDefault` where default couldn't be overridden when content was passed as a block.
71-
* Fix bug where request-aware helpers did not work outside of the request context.
72-
* `ViewComponentsSystemTestController` should not be useable outside of test environment
71+
* Fix bug where request-aware helpers didn't work outside of the request context.
72+
* `ViewComponentsSystemTestController` shouldn't be useable outside of test environment
7373

7474
### Non-functional changes
7575

@@ -99,7 +99,7 @@ Please report any issues at [https://github.com/ViewComponent/view_component/iss
9999

100100
*Joel Hawksley*
101101

102-
* Fix bug where `config.previews.enabled` did not function properly in production environments.
102+
* Fix bug where `config.previews.enabled` didn't function properly in production environments.
103103

104104
*Joel Hawksley*
105105

@@ -234,11 +234,11 @@ This release makes the following breaking changes:
234234

235235
* BREAKING: Use ActionView's `lookup_context` for picking templates instead of the request format.
236236

237-
3.15 added support for using templates that match the request format, i.e. if `/resource.csv` is requested then
237+
3.15 added support for using templates that match the request format, that is if `/resource.csv` is requested then
238238
ViewComponents would pick `_component.csv.erb` over `_component.html.erb`.
239239

240240
With this release, the request format is no longer considered and instead ViewComponent will use the Rails logic
241-
for picking the most appropriate template type, i.e. the csv template will be used if it matches the `Accept` header
241+
for picking the most appropriate template type, that is the csv template will be used if it matches the `Accept` header
242242
or because the controller uses a `respond_to` block to pick the response format.
243243

244244
*Stephen Nelson*
@@ -247,11 +247,11 @@ This release makes the following breaking changes:
247247

248248
*Joel Hawksley*
249249

250-
* Fix bug where request-aware helpers did not work outside of the request context.
250+
* Fix bug where request-aware helpers didn't work outside of the request context.
251251

252252
*Joel Hawksley*, *Stephen Nelson*
253253

254-
* `ViewComponentsSystemTestController` should not be useable outside of test environment
254+
* `ViewComponentsSystemTestController` shouldn't be useable outside of test environment
255255

256256
*Joel Hawksley*, *Stephen Nelson*
257257

docs/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ nav_order: 1
88

99
A framework for creating reusable, testable & encapsulated view components, built to integrate seamlessly with Ruby on Rails.
1010

11-
_As of version 4, ViewComponent is in Long-Term Support and generally considered feature-complete._
11+
_As of version 4, ViewComponent is in Long-Term Support and considered feature-complete._
1212

1313
## What's a ViewComponent?
1414

0 commit comments

Comments
 (0)