remove unnecessary v prefix from version tags (#2186)

* remove unnecessary v prefix from version tags

As @bkuhlmann espoused in a recent Boulder Ruby talk on Milestones
(https://alchemists.io/articles/milestones), the `v` prefix is
unnecessary and not Ruby convention.

* add changelog

Author: joelhawksley

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 5
 
 ## main
 
+* Do not prefix release tags with `v`, per recommendation from @bkuhlmann.
+
+    *Joel Hawksley*
+
 ## 3.21.0
 
 * Updates testing docs to include an example of how to use with RSpec.

script/release

@@ -19,7 +19,7 @@ remote_history_is_clean() {
 }
 
 tag_exists_on_remote() {
-  git rev-parse --quiet --verify refs/tags/v$1.$2.$3 > /dev/null
+  git rev-parse --quiet --verify refs/tags/$1.$2.$3 > /dev/null
 }
 
 working_tree_is_clean() {
@@ -28,7 +28,7 @@ working_tree_is_clean() {
 }
 
 create_release_branch() {
-  git switch -c release-v$1-$2-$3
+  git switch -c release-$1-$2-$3
 }
 
 update_readme() {
@@ -77,7 +77,7 @@ commit() {
 }
 
 push() {
-  git push origin release-v$1-$2-$3
+  git push origin release-$1-$2-$3
 
   echo "####################################################"
   echo "Now, open a PR with this branch and merge it to main"