Fix bug where mkdir_p failed due to incorrect permissions. (#1688)

Author: joelhawksley

Gemfile.lock

@@ -303,9 +303,6 @@ DEPENDENCIES
   jbuilder (~> 2)
   m (~> 1)
   minitest (= 5.6.0)
-  net-imap
-  net-pop
-  net-smtp
   pry (~> 0.13)
   puma (~> 5)
   rails (~> 7.0.0)

app/controllers/view_components_system_test_controller.rb

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
 
 class ViewComponentsSystemTestController < ActionController::Base # :nodoc:
-  TEMP_DIR = FileUtils.mkdir_p("./tmp/view_components/").first
-
   before_action :validate_test_env
   before_action :validate_file_path
 
+  def self.temp_dir
+    @_tmpdir ||= FileUtils.mkdir_p("./tmp/view_components/").first
+  end
+
   def system_test_entrypoint
     render file: @path
   end
@@ -19,7 +21,7 @@ def validate_test_env
   # Ensure that the file path is valid and doesn't target files outside
   # the expected directory (e.g. via a path traversal or symlink attack)
   def validate_file_path
-    base_path = ::File.realpath(TEMP_DIR)
+    base_path = ::File.realpath(self.class.temp_dir)
     @path = ::File.realpath(params.permit(:file)[:file], base_path)
     unless @path.start_with?(base_path)
       raise ArgumentError, "Invalid file path"

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 5
 
 ## main
 
+* Fix bug where `mkdir_p` failed due to incorrect permissions.
+
+    *Joel Hawksley*
+
 * Check for inline `erb_template` calls when deciding whether or not to compile a component's superclass.
 
     *Justin Kenyon*

lib/view_component/system_test_helpers.rb

@@ -12,7 +12,7 @@ module SystemTestHelpers
     def with_rendered_component_path(fragment, layout: false, &block)
       file = Tempfile.new(
         ["rendered_#{fragment.class.name}", ".html"],
-        ViewComponentsSystemTestController::TEMP_DIR
+        ViewComponentsSystemTestController.temp_dir
       )
       begin
         file.write(vc_test_controller.render_to_string(html: fragment.to_html.html_safe, layout: layout))