Skip to content

Commit cae0504

Browse files
authored
remove TODO for slot name collisions (#2248)
After giving this a deep read, I'm not convinced we should change this behavior. I'm removing the TODO.
1 parent 6f3a1ab commit cae0504

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/view_component/slotable.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,6 @@ def validate_singular_slot_name(slot_name)
333333

334334
def raise_if_slot_registered(slot_name)
335335
if registered_slots.key?(slot_name)
336-
# TODO remove? This breaks overriding slots when slots are inherited
337336
raise RedefinedSlotError.new(name, slot_name)
338337
end
339338
end

0 commit comments

Comments
 (0)