Update filter in source_location to use base_label (#2009)

* Update filter in source_location to use base_label

Co-authored-by: jasonkim <[email protected]>

* Add more context to changelog and code comment

* Update docs/CHANGELOG.md

* Add allan-pires and jasonkim to contributors list

---------

Co-authored-by: jasonkim <[email protected]>
Co-authored-by: Joel Hawksley <[email protected]>

Author: 3 people

docs/CHANGELOG.md

@@ -10,6 +10,12 @@ nav_order: 5
 
 ## main
 
+* Fix templates not being correctly populated when caller location label has a prefix.
+
+On the upstream version of Ruby, method owners are now included in backtraces as prefixes. This caused the call stack filtering to not work as intended and thus `source_location` to be incorrect for child ViewComponents, consequently not populating templates correctly.
+
+    *Allan Pires, Jason Kim*
+
 * Use component path for generating RSpec files.
 
 When generating new RSpec files for components, the generator will use the `view_component_path` value in the config to decide where to put the new spec file. For instance, if the `view_component_path` option has been changed to `app/views/components`, the generator will put the spec file in `spec/views/components`. **If the `view_component_path` doesn't start with `app/`, then the generator will fall back to `spec/components/`.**

docs/index.md

@@ -218,6 +218,8 @@ ViewComponent is built by over a hundred members of the community, including:
 <img src="https://avatars.githubusercontent.com/aduth?s=64" alt="aduth" width="32" />
 <img src="https://avatars.githubusercontent.com/htcarr3?s=64" alt="htcarr3" width="32" />
 <img src="https://avatars.githubusercontent.com/neanias?s=64" alt="neanias" width="32" />
+<img src="https://avatars.githubusercontent.com/allan-pires?s=64" alt="allan-pires" width="32" />
+<img src="https://avatars.githubusercontent.com/jasonkim?s=64" alt="jasonkim" width="32" />
 
 ## Who uses ViewComponent?
 

lib/view_component/base.rb

@@ -537,7 +537,9 @@ def render_template_for(variant = nil)
         # Derive the source location of the component Ruby file from the call stack.
         # We need to ignore `inherited` frames here as they indicate that `inherited`
         # has been re-defined by the consuming application, likely in ApplicationComponent.
-        child.source_location = caller_locations(1, 10).reject { |l| l.label == "inherited" }[0].path
+        # We use `base_label` method here instead of `label` to avoid cases where the method
+        # owner is included in a prefix like `ApplicationComponent.inherited`.
+        child.source_location = caller_locations(1, 10).reject { |l| l.base_label == "inherited" }[0].path
 
         # If Rails application is loaded, removes the first part of the path and the extension.
         if defined?(Rails) && Rails.application