Skip to content

Commit c2f7d15

Browse files
committed
- downgrade Mapsui to beta 17 to avoid beta 18 not working on android Mapsui/Mapsui#3051. Note that beta 17 only works on Android when using the Uno native renderer, not the Uno Skia renderer.
- fix targetframeworks to support Skia and Native renderers - fix Windows PRI build errors in example
1 parent 6edb8c9 commit c2f7d15

File tree

12 files changed

+40
-381
lines changed

12 files changed

+40
-381
lines changed

src/CSharpMarkup.WinUI.Examples/Directory.Packages.props

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,15 @@
1111
<ItemGroup>
1212
<PackageVersion Include="CSharpMarkup.WinUI" Version="3.1.2" />
1313
<PackageVersion Include="CSharpMarkup.WinUI.LiveChartsCore.SkiaSharpView" Version="3.1.2" />
14-
<PackageVersion Include="CSharpMarkup.WinUI.Mapsui" Version="3.1.2" />
14+
<PackageVersion Include="CSharpMarkup.WinUI.Mapsui" Version="3.1.2-beta.17.3" />
1515
<PackageVersion Include="CSharpMarkup.WinUI.ScottPlot" Version="3.1.2" />
1616
<PackageVersion Include="CSharpMarkup.WinUI.Uno.Extensions.Navigation" Version="3.1.2" />
1717
<PackageVersion Include="CSharpMarkup.WinUI.Uno.Extensions.Navigation.Toolkit" Version="3.1.2" />
1818
<PackageVersion Include="CSharpMarkup.WinUI.Uno.Toolkit" Version="3.1.2" />
19-
<!-- Pinned for Mapsui; keep consistent with https://github.com/Mapsui/Mapsui/blob/main/Directory.Packages.props, TODO: remove when Uno SDK with SkiaRenderer feature depends on this or higher version -->
20-
<PackageVersion Include="SkiaSharp.Views.Uno.WinUI" Version="3.119.0" />
21-
<PackageVersion Include="SkiaSharp.Skottie" Version="3.119.0" />
19+
20+
<!-- Pinned to the version that Uno SDK implicitly references, to prevent PRI errors when building the Windows target.
21+
Update versions when updating Uno SDK. -->
22+
<PackageVersion Include="Uno.Toolkit.WinUI" Version="7.0.7" />
23+
<PackageVersion Include="Uno.Extensions.Navigation.Toolkit.WinUI" Version="6.0.12" />
2224
</ItemGroup>
23-
</Project>
25+
</Project>

src/CSharpMarkup.WinUI.Mapsui/CSharpMarkup.WinUI.Mapsui.csproj

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
<EnableDefaultPageItems>false</EnableDefaultPageItems>
1212
<UnoSingleProject>true</UnoSingleProject>
1313
<OutputType>Library</OutputType>
14-
<UnoFeatures>
15-
SkiaRenderer;
16-
</UnoFeatures>
1714
</PropertyGroup>
1815

1916
<PropertyGroup>
@@ -33,7 +30,7 @@
3330
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
3431
<RepositoryType>git</RepositoryType>
3532
<Product>$(AssemblyName) ($(TargetFramework))</Product>
36-
<Version>$(CSharpMarkupVersion)-beta.18</Version> <!-- Keep the beta version suffix equal to Mapsui 5.0.0-beta.<nr>, remove when out of beta -->
33+
<Version>$(CSharpMarkupVersion)-beta.17.3</Version> <!-- Keep the beta version suffix equal to Mapsui 5.0.0-beta.<nr>, remove when out of beta -->
3734
<NeutralLanguage>en</NeutralLanguage>
3835

3936
<NoWarn>CS1591;CS1573;Uno0001</NoWarn>
@@ -52,8 +49,8 @@
5249
</PropertyGroup>
5350

5451
<PropertyGroup>
55-
<TargetFrameworks>net8.0;net8.0-ios;net8.0-maccatalyst;net8.0-android;net8.0-windows10.0.19041;net8.0-browserwasm;net8.0-desktop;net9.0;net9.0-ios;net9.0-maccatalyst;net9.0-android;net9.0-browserwasm;net9.0-windows10.0.19041;net9.0-desktop</TargetFrameworks>
56-
<!-- Identical to Mapsui.Uno.WinUI 5 target frameworks, see https://github.com/Mapsui/Mapsui/blob/main/Mapsui.UI.Uno.WinUI/Mapsui.UI.Uno.WinUI.csproj -->
52+
<TargetFrameworks>net8.0;net8.0-ios17.0;net8.0-maccatalyst17.0;net8.0-android34.0;net8.0-windows10.0.19041.0;net9.0;net9.0-ios18.4;net9.0-maccatalyst18.4;net9.0-android35.0;net9.0-windows10.0.19041.0</TargetFrameworks>
53+
<!-- Derived from Mapsui.Uno.WinUI 5 target frameworks, adjusted to C#M targetframeworks. See https://github.com/Mapsui/Mapsui/blob/main/Mapsui.UI.Uno.WinUI/Mapsui.UI.Uno.WinUI.csproj -->
5754
<RootNamespace>CSharpMarkup.WinUI.Mapsui</RootNamespace>
5855
<EnableDefaultPageItems>false</EnableDefaultPageItems>
5956
</PropertyGroup>
@@ -66,8 +63,6 @@
6663
<PackageReference Include="Mapsui.Uno.WinUI" />
6764
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
6865
<PackageReference Include="CSharpMarkup.WinUI" />
69-
<PackageReference Include="SkiaSharp.Views.Uno.WinUI" />
70-
<PackageReference Include="SkiaSharp.Skottie" />
7166
</ItemGroup>
7267

7368
<ItemGroup>

src/CSharpMarkup.WinUI.Mapsui/Generated/SourceGenerators/SourceGenerators.CsMarkupApiSourceGenerator/UnoWinUI.NET8_0_Android.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,13 @@ public static MapControl MapControl()
3737
var ui = new Mui.MapControl();
3838
return CSharpMarkup.WinUI.Mapsui.MapControl.StartChain(ui);
3939
}
40+
41+
/// <summary>Create a <see cref="Mui.MapControl"/></summary>
42+
public static MapControl MapControl(nint javaReference, Android.Runtime.JniHandleOwnership transfer)
43+
{
44+
var ui = new Mui.MapControl(javaReference, transfer);
45+
return CSharpMarkup.WinUI.Mapsui.MapControl.StartChain(ui);
46+
}
4047
}
4148

4249
public partial class MapControl : Grid, IUI<Mui.MapControl>

src/CSharpMarkup.WinUI.Mapsui/Generated/SourceGenerators/SourceGenerators.CsMarkupApiSourceGenerator/UnoWinUI.NET8_0_BrowserWasm.cs

Lines changed: 0 additions & 87 deletions
This file was deleted.

src/CSharpMarkup.WinUI.Mapsui/Generated/SourceGenerators/SourceGenerators.CsMarkupApiSourceGenerator/UnoWinUI.NET8_0_Desktop.cs

Lines changed: 0 additions & 87 deletions
This file was deleted.

src/CSharpMarkup.WinUI.Mapsui/Generated/SourceGenerators/SourceGenerators.CsMarkupApiSourceGenerator/UnoWinUI.NET8_0_MacCatalyst.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,20 +37,6 @@ public static MapControl MapControl()
3737
var ui = new Mui.MapControl();
3838
return CSharpMarkup.WinUI.Mapsui.MapControl.StartChain(ui);
3939
}
40-
41-
/// <summary>Create a <see cref="Mui.MapControl"/></summary>
42-
public static MapControl MapControl(nint handle)
43-
{
44-
var ui = new Mui.MapControl(handle);
45-
return CSharpMarkup.WinUI.Mapsui.MapControl.StartChain(ui);
46-
}
47-
48-
/// <summary>Create a <see cref="Mui.MapControl"/></summary>
49-
public static MapControl MapControl(ObjCRuntime.NativeHandle handle)
50-
{
51-
var ui = new Mui.MapControl(handle);
52-
return CSharpMarkup.WinUI.Mapsui.MapControl.StartChain(ui);
53-
}
5440
}
5541

5642
public partial class MapControl : Grid, IUI<Mui.MapControl>

src/CSharpMarkup.WinUI.Mapsui/Generated/SourceGenerators/SourceGenerators.CsMarkupApiSourceGenerator/UnoWinUI.NET9_0_Android.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,13 @@ public static MapControl MapControl()
3737
var ui = new Mui.MapControl();
3838
return CSharpMarkup.WinUI.Mapsui.MapControl.StartChain(ui);
3939
}
40+
41+
/// <summary>Create a <see cref="Mui.MapControl"/></summary>
42+
public static MapControl MapControl(nint javaReference, Android.Runtime.JniHandleOwnership transfer)
43+
{
44+
var ui = new Mui.MapControl(javaReference, transfer);
45+
return CSharpMarkup.WinUI.Mapsui.MapControl.StartChain(ui);
46+
}
4047
}
4148

4249
public partial class MapControl : Grid, IUI<Mui.MapControl>

src/CSharpMarkup.WinUI.Mapsui/Generated/SourceGenerators/SourceGenerators.CsMarkupApiSourceGenerator/UnoWinUI.NET9_0_BrowserWasm.cs

Lines changed: 0 additions & 87 deletions
This file was deleted.

0 commit comments

Comments
 (0)