Add phpstan deprecation rule

Author: VincentLanglet

composer.json

@@ -27,6 +27,7 @@
         "friendsofphp/php-cs-fixer": "^3.13.0",
         "infection/infection": "^0.26.16 || ^0.32.0",
         "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-phpunit": "^2.0",
         "phpstan/phpstan-strict-rules": "^2.0",
         "phpstan/phpstan-symfony": "^2.0",

phpstan.neon

@@ -4,6 +4,7 @@ includes:
     - vendor/phpstan/phpstan-symfony/extension.neon
     - vendor/phpstan/phpstan-symfony/rules.neon
     - vendor/phpstan/phpstan-webmozart-assert/extension.neon
+    - vendor/phpstan/phpstan-deprecation-rules/rules.neon
     - vendor/phpstan/phpstan-strict-rules/rules.neon
     - vendor/phpstan/phpstan/conf/bleedingEdge.neon
 

src/Environment/Parser/ComponentTokenParser.php

@@ -57,12 +57,14 @@ private function parseArguments(): void
 
     private function parseExpression(): void
     {
-        // @phpstan-ignore-next-line
-        if (method_exists($this->parser, 'parseExpression')) {
-            // Since Twig 3.21
+        // @phpstan-ignore-next-line function.alreadyNarrowedType
+        if (method_exists($this->parser, 'parseExpression')) { // Since Twig 3.21
             $this->parser->parseExpression();
         } else {
+            // @codeCoverageIgnoreStart
+            // @phpstan-ignore-next-line method.deprecated, method.deprecatedClass
             $this->parser->getExpressionParser()->parseExpression();
+            // @codeCoverageIgnoreEnd
         }
     }
 }

src/Token/Tokenizer.php

@@ -799,9 +799,9 @@ private function getOperatorRegex(Environment $env): string
             }
         } else {
             // @codeCoverageIgnoreStart
-            // @phpstan-ignore-next-line
+            // @phpstan-ignore-next-line method.notFound, argument.type
             $unaryOperators = array_keys($env->getUnaryOperators());
-            // @phpstan-ignore-next-line
+            // @phpstan-ignore-next-line method.notFound, argument.type
             $binaryOperators = array_keys($env->getBinaryOperators());
             $expressionParsers = [...$unaryOperators, ...$binaryOperators];
             // @codeCoverageIgnoreEnd

tests/Environment/Fixtures/CustomTokenParser.php

@@ -13,6 +13,7 @@ final class CustomTokenParser extends AbstractTokenParser
     public function parse(Token $token): Node
     {
         if (!$this->parser->getStream()->test(Token::BLOCK_END_TYPE)) {
+            // @phpstan-ignore-next-line method.deprecated, method.deprecatedClass
             $this->parser->getExpressionParser()->parseMultitargetExpression();
         }
         $this->parser->getStream()->expect(Token::BLOCK_END_TYPE);

tests/Token/Tokenizer/Fixtures/CustomTwigExtension.php

@@ -46,7 +46,7 @@ public function getOperators(): array
             ['+sum' => [
                 'precedence' => 0,
                 'class' => AddBinary::class,
-                'associativity' => ExpressionParser::OPERATOR_RIGHT,
+                'associativity' => ExpressionParser::OPERATOR_RIGHT, // @phpstan-ignore classConstant.deprecatedClass
             ]],
         ];
     }