Simplify inline conditions with ?? operator

[ruudk]

Would it be possible to do some optimizations like replacing:

{{ user and user.locationCountry.value ?? '' }}

and change it to

{{ user.locationCountry.value ?? '' }}

The initial code was written because user can be null and it's chaining multiple levels deep is not expected to work.

But the ?? operator in Twig takes care of this already.

{{ blaat.test.something.else.whatever ?? '' }}

is perfectly valid.

Twig Playground

[ruudk]

Maybe we need AbstractNodeRule for this, and then make it possible to use that together with Fixable interface.

[VincentLanglet]

Maybe we need AbstractNodeRule for this, and then make it possible to use that together with Fixable interface.

I don't think NodeRules can be fixable since it rely on Node, and Twig parser is losing every comment and spaces.

You should work with "classic" Rules and all the token types this lib provides.

For instance you can

• listen all the ?? of the file,
• look at the value before, ignoring spaces, (user.locationCountry.value) by recursively looking for NAME_TYPE and PUNCTUATION_TYPE
• look for the value before, ignoring spaces, and
• and then look for the NAME_TYPE before