Resolve #98, get rid of repetitive string constant

Author: Dmitry-Me

CPPCheckPlugin/CPPCheckPluginPackage.cs

@@ -210,7 +210,7 @@ private void documentSaved(Document document)
 			if (document == null || document.Language != "C/C++")
 				return;
 
-			if (Properties.Settings.Default["CheckSavedFiles"] != null && Properties.Settings.Default.CheckSavedFiles == false)
+			if (Properties.Settings.Default[Properties.Settings.CheckSavedFilesOptionKeyName] != null && Properties.Settings.Default.CheckSavedFiles == false)
 				return;
 
 			if (document.ActiveWindow == null)
@@ -240,7 +240,7 @@ private void documentSaved(Document document)
 				if (sourceForAnalysis == null)
 					return;
 
-				if (Properties.Settings.Default["CheckSavedFiles"] == null)
+				if (Properties.Settings.Default[Properties.Settings.CheckSavedFilesOptionKeyName] == null)
 				{
 					askCheckSavedFiles();
 

CPPCheckPlugin/CppcheckSettings.xaml.cs

@@ -34,20 +34,25 @@ public CppcheckSettings()
 
 			Properties.Settings.Default.Save();
 
-			if (Properties.Settings.Default["CheckSavedFiles"] == null)
+			if (Properties.Settings.Default[Properties.Settings.CheckSavedFilesOptionKeyName] == null)
 			{
 				CPPCheckPluginPackage.askCheckSavedFiles();
 			}
 		}
 
 		private void onActivated(object o, EventArgs e)
 		{
-			InconclusiveChecks.IsChecked = Properties.Settings.Default.InconclusiveChecksEnabled;
+			var settings = Properties.Settings.Default;
 
-			CheckSavedFiles.IsChecked = Properties.Settings.Default.CheckSavedFiles;
-			Project_OnlyCheckCurrentConfig.IsChecked = Properties.Settings.Default.ProjectOnlyCheckCurrentConfig;
-			File_OnlyCheckCurrentConfig.IsChecked = Properties.Settings.Default.FileOnlyCheckCurrentConfig;
-			ArgumentsEditor.Text = Properties.Settings.Default.DefaultArguments;
+			InconclusiveChecks.IsChecked = settings.InconclusiveChecksEnabled;
+
+			if (settings[Properties.Settings.CheckSavedFilesOptionKeyName] == null)
+				CheckSavedFiles.IsChecked = false;
+			else
+				CheckSavedFiles.IsChecked = settings.CheckSavedFiles;
+			Project_OnlyCheckCurrentConfig.IsChecked = settings.ProjectOnlyCheckCurrentConfig;
+			File_OnlyCheckCurrentConfig.IsChecked = settings.FileOnlyCheckCurrentConfig;
+			ArgumentsEditor.Text = settings.DefaultArguments;
 		}
 
 		private void OnClosed(object o, EventArgs e)
@@ -70,13 +75,13 @@ private void inconclusive_Checked(object sender, RoutedEventArgs e)
 
 		private void checkSavedFiles_Unchecked(object sender, RoutedEventArgs e)
 		{
-			Properties.Settings.Default["CheckSavedFiles"] = false;
+			Properties.Settings.Default[Properties.Settings.CheckSavedFilesOptionKeyName] = false;
 			Properties.Settings.Default.Save();
 		}
 
 		private void checkSavedFiles_Checked(object sender, RoutedEventArgs e)
 		{
-			Properties.Settings.Default["CheckSavedFiles"] = true;
+			Properties.Settings.Default[Properties.Settings.CheckSavedFilesOptionKeyName] = true;
 			Properties.Settings.Default.Save();
 		}
 

CPPCheckPlugin/Settings.cs

@@ -24,5 +24,7 @@ private void SettingChangingEventHandler(object sender, System.Configuration.Set
         private void SettingsSavingEventHandler(object sender, System.ComponentModel.CancelEventArgs e) {
             // Add code to handle the SettingsSaving event here.
         }
+
+        public const string CheckSavedFilesOptionKeyName = "CheckSavedFiles";
     }
 }