Skip to content

Commit 0ff85fb

Browse files
fix: resolve CodeRabbit import style issues in main.py
- Add FallbackHashEmbeddings to existing relative import on line 46 - Remove redundant absolute imports in _get_fallback_embeddings function - Use consistent relative import style throughout the file - Simplify function by removing unnecessary import statements This addresses CodeRabbit's feedback about: - Redundant import of contextforge_memory.embeddings.base - Inconsistent import style (absolute vs relative) - Unnecessary complexity in _get_fallback_embeddings function
1 parent e644bd1 commit 0ff85fb

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/contextforge_memory/main.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
if TYPE_CHECKING:
4444
import numpy as np
4545

46-
from .embeddings.base import EmbeddingsProvider
46+
from .embeddings.base import EmbeddingsProvider, FallbackHashEmbeddings
4747
from .ephemeral.session_store import SessionStore
4848
from .summarize.base import HeuristicSummarizer
4949
from .vector_index.in_memory_index import InMemoryCosineIndex
@@ -917,18 +917,14 @@ def get_provider_config() -> ProviderConfig:
917917

918918

919919
def _get_fallback_embeddings(dimension: int) -> EmbeddingsProvider:
920-
"""Get a FallbackHashEmbeddings instance with direct import.
920+
"""Get a FallbackHashEmbeddings instance.
921921
922922
Args:
923923
dimension: The embedding dimension to use
924924
925925
Returns:
926926
Initialized FallbackHashEmbeddings provider
927927
"""
928-
# Import the parent module first to ensure it's in sys.modules
929-
import contextforge_memory.embeddings.base # noqa: F401
930-
from contextforge_memory.embeddings.base import FallbackHashEmbeddings
931-
932928
return FallbackHashEmbeddings(dimension)
933929

934930

0 commit comments

Comments
 (0)