refactor: move test_json_handler.py to proper tests directory

- Move test_json_handler.py from root to tests/ directory
- Update import path to work from tests/ directory
- Remove duplicate pathlib import
- Add T20 (print statements) to per-file-ignores for test files
- Fix line length issues and unused variables
- Remove unnecessary open mode parameters
- Break long strings to comply with 88 character limit
- Maintain all test functionality and imports

This follows proper Python project structure where test files belong in the tests/ directory and allows print statements in test files for demonstration purposes.

Author: AlmostBald-TRADING

pyproject.toml

@@ -25,9 +25,9 @@ fixable = ["I"]
 [tool.ruff.lint.per-file-ignores]
 "example_usage.py" = ["T20"]
 ".github/scripts/analyze_vulnerabilities.py" = ["T20"]
-"tests/**/*.py" = ["S101"]  # Allow assert statements in test files
-"**/test_*.py" = ["S101"]  # Allow assert statements in test files
-"**/*_test.py" = ["S101"]  # Allow assert statements in test files
+"tests/**/*.py" = ["S101", "T20"]  # Allow assert statements and print in test files
+"**/test_*.py" = ["S101", "T20"]  # Allow assert statements and print in test files
+"**/*_test.py" = ["S101", "T20"]  # Allow assert statements and print in test files
 
 [tool.isort]
 profile = "black"

test_json_handler.py tests/test_json_handler.pytest_json_handler.py renamed to tests/test_json_handler.py

@@ -4,79 +4,94 @@
 """
 
 import json
+import sys
 import tempfile
 from pathlib import Path
-from scripts.handlers.json_handler import apply_json_suggestion, validate_json_suggestion, has_duplicate_keys
+
+# Add the scripts directory to the path
+sys.path.insert(0, str(Path(__file__).parent.parent / "scripts"))
+
+from handlers.json_handler import (
+    apply_json_suggestion,
+    has_duplicate_keys,
+    validate_json_suggestion,
+)
+
 
 def test_duplicate_key_detection():
     """Test that duplicate keys are detected."""
     print("Testing duplicate key detection...")
 
     # Test JSON string with duplicate keys (like the original problem)
-    duplicate_json = '''
+    duplicate_json = """
     {
         "name": "@contextforge/memory-client",
         "version": "0.1.0",
         "name": "@contextforge/memory-client",
         "version": "0.1.0",
         "type": "module"
     }
-    '''
+    """
 
     # Parse the JSON - this should fail due to duplicate keys
     try:
-        duplicate_data = json.loads(duplicate_json)
+        json.loads(duplicate_json)
         # If we get here, Python's JSON parser didn't catch it
         # (which is expected - JSON parsers typically keep the last value)
         print("Note: JSON parser kept last values for duplicate keys")
     except json.JSONDecodeError:
         print("Note: JSON parser rejected duplicate keys")
 
     # Test data without duplicate keys
-    clean_data = {
-        "name": "test",
-        "version": "1.0.0",
-        "description": "test package"
-    }
+    clean_data = {"name": "test", "version": "1.0.0", "description": "test package"}
 
-    assert not has_duplicate_keys(clean_data), "Should not detect duplicates in clean data"
+    assert not has_duplicate_keys(
+        clean_data
+    ), "Should not detect duplicates in clean data"
     print("✓ Clean data validation works")
 
+
 def test_json_suggestion_application():
     """Test applying JSON suggestions."""
     print("\nTesting JSON suggestion application...")
 
     # Create a temporary JSON file
-    with tempfile.NamedTemporaryFile(mode='w', suffix='.json', delete=False) as f:
+    with tempfile.NamedTemporaryFile(mode="w", suffix=".json", delete=False) as f:
         original_data = {
             "name": "@contextforge/memory-client",
             "version": "0.1.0",
             "type": "module",
-            "description": "TypeScript client for ContextForge Memory API"
+            "description": "TypeScript client for ContextForge Memory API",
         }
         json.dump(original_data, f, indent=2)
         temp_path = f.name
 
     try:
         # Test valid suggestion
-        valid_suggestion = json.dumps({
-            "name": "@contextforge/memory-client",
-            "version": "0.1.0",
-            "type": "module",
-            "description": "TypeScript client for ContextForge Memory API with v0 and v1 support",
-            "main": "dist/index.cjs",
-            "module": "dist/index.esm.js",
-            "types": "dist/types/index.d.ts",
-            "sideEffects": False,
-            "exports": {
-                ".": {
-                    "import": "./dist/index.esm.js",
-                    "require": "./dist/index.cjs",
-                    "types": "./dist/types/index.d.ts"
+        valid_suggestion = json.dumps(
+            {
+                "name": "@contextforge/memory-client",
+                "version": "0.1.0",
+                "type": "module",
+                "description": (
+                    "TypeScript client for ContextForge Memory API "
+                    "with v0 and v1 support"
+                ),
+                "main": "dist/index.cjs",
+                "module": "dist/index.esm.js",
+                "types": "dist/types/index.d.ts",
+                "sideEffects": False,
+                "exports": {
+                    ".": {
+                        "import": "./dist/index.esm.js",
+                        "require": "./dist/index.cjs",
+                        "types": "./dist/types/index.d.ts",
+                    },
+                    "./package.json": "./package.json",
                 },
-                "./package.json": "./package.json"
-            }
-        }, indent=2)
+            },
+            indent=2,
+        )
 
         # Validate suggestion
         is_valid, msg = validate_json_suggestion(temp_path, valid_suggestion, 1, 1)
@@ -89,7 +104,7 @@ def test_json_suggestion_application():
         print("✓ Valid suggestion application works")
 
         # Verify the file was updated correctly
-        with open(temp_path, 'r') as f:
+        with open(temp_path) as f:
             updated_data = json.load(f)
 
         assert "exports" in updated_data, "Exports field should be added"
@@ -100,64 +115,75 @@ def test_json_suggestion_application():
         # Clean up
         Path(temp_path).unlink()
 
+
 def test_duplicate_key_prevention():
     """Test that duplicate keys are prevented."""
     print("\nTesting duplicate key prevention...")
 
     # Create a temporary JSON file
-    with tempfile.NamedTemporaryFile(mode='w', suffix='.json', delete=False) as f:
-        original_data = {
-            "name": "@contextforge/memory-client",
-            "version": "0.1.0"
-        }
+    with tempfile.NamedTemporaryFile(mode="w", suffix=".json", delete=False) as f:
+        original_data = {"name": "@contextforge/memory-client", "version": "0.1.0"}
         json.dump(original_data, f, indent=2)
         temp_path = f.name
 
     try:
         # Test suggestion that would create duplicates when merged
         # This simulates the original package.json problem
-        suggestion_with_potential_duplicates = json.dumps({
-            "name": "@contextforge/memory-client",
-            "version": "0.1.0",
-            "type": "module",
-            "description": "TypeScript client for ContextForge Memory API with v0 and v1 support",
-            "main": "dist/index.cjs",
-            "module": "dist/index.esm.js",
-            "types": "dist/types/index.d.ts",
-            "sideEffects": False,
-            "exports": {
-                ".": {
-                    "import": "./dist/index.esm.js",
-                    "require": "./dist/index.cjs",
-                    "types": "./dist/types/index.d.ts"
+        suggestion_with_potential_duplicates = json.dumps(
+            {
+                "name": "@contextforge/memory-client",
+                "version": "0.1.0",
+                "type": "module",
+                "description": (
+                    "TypeScript client for ContextForge Memory API "
+                    "with v0 and v1 support"
+                ),
+                "main": "dist/index.cjs",
+                "module": "dist/index.esm.js",
+                "types": "dist/types/index.d.ts",
+                "sideEffects": False,
+                "exports": {
+                    ".": {
+                        "import": "./dist/index.esm.js",
+                        "require": "./dist/index.cjs",
+                        "types": "./dist/types/index.d.ts",
+                    },
+                    "./package.json": "./package.json",
                 },
-                "./package.json": "./package.json"
-            }
-        }, indent=2)
+            },
+            indent=2,
+        )
 
         # This should pass validation (no duplicates in suggestion itself)
-        is_valid, msg = validate_json_suggestion(temp_path, suggestion_with_potential_duplicates, 1, 1)
+        is_valid, msg = validate_json_suggestion(
+            temp_path, suggestion_with_potential_duplicates, 1, 1
+        )
         assert is_valid, f"Valid suggestion should pass validation: {msg}"
         print("✓ Valid suggestion validation works")
 
         # This should be applied successfully
-        result = apply_json_suggestion(temp_path, suggestion_with_potential_duplicates, 1, 1)
+        result = apply_json_suggestion(
+            temp_path, suggestion_with_potential_duplicates, 1, 1
+        )
         assert result, "Valid suggestion should be applied successfully"
         print("✓ Valid suggestion application works")
 
         # Verify the file was updated correctly
-        with open(temp_path, 'r') as f:
+        with open(temp_path) as f:
             updated_data = json.load(f)
 
         assert "exports" in updated_data, "Exports field should be added"
         assert updated_data["main"] == "dist/index.cjs", "Main field should be updated"
-        assert updated_data["name"] == "@contextforge/memory-client", "Name should be preserved"
+        assert (
+            updated_data["name"] == "@contextforge/memory-client"
+        ), "Name should be preserved"
         print("✓ File was updated correctly without duplicates")
 
     finally:
         # Clean up
         Path(temp_path).unlink()
 
+
 if __name__ == "__main__":
     print("Testing JSON Handler for CodeRabbit Suggestions")
     print("=" * 50)