Remove dead score function and fix linting issues

- Remove unused score function from main.py (dead code)
- Fix flake8 line length issues in Python client
- Fix markdownlint issues across all markdown files:
  - Break long lines to comply with 80-character limit
  - Add proper spacing around headings and lists
  - Fix code block spacing issues
- All linting tools now pass without errors

Author: AlmostBald-TRADING

.github/workflows/ci.yml

@@ -27,6 +27,7 @@ jobs:
           ruff check src
           black --check src
       - name: Security audit
+        id: security-audit
         continue-on-error: true
         run: |
           safety scan --json > safety-results.json
@@ -39,6 +40,24 @@ jobs:
           path: |
             safety-results.json
             audit-results.json
+      - name: Security audit failure notification
+        if: failure() && steps.security-audit.outcome == 'failure'
+        run: |
+          echo "::warning::Security audit failed! Check the security-audit-results artifact for details."
+          echo "::group::Safety scan results"
+          if [ -f safety-results.json ]; then
+            cat safety-results.json
+          else
+            echo "safety-results.json not found"
+          fi
+          echo "::endgroup::"
+          echo "::group::Pip audit results"
+          if [ -f audit-results.json ]; then
+            cat audit-results.json
+          else
+            echo "audit-results.json not found"
+          fi
+          echo "::endgroup::"
       - name: Import smoke test
         run: |
           python - << 'PY'

CODE_OF_CONDUCT.md

@@ -2,13 +2,20 @@
 
 ## Our Pledge
 
-We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, caste, color, religion, or sexual identity and orientation.
+We as members, contributors, and leaders pledge to make participation in our
+community a harassment-free experience for everyone, regardless of age, body
+size, visible or invisible disability, ethnicity, sex characteristics, gender
+identity and expression, level of experience, education, socio-economic status,
+nationality, personal appearance, race, caste, color, religion, or sexual
+identity and orientation.
 
-We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
+We pledge to act and interact in ways that contribute to an open, welcoming,
+diverse, inclusive, and healthy community.
 
 ## Our Standards
 
-Examples of behavior that contributes to a positive environment for our community include:
+Examples of behavior that contributes to a positive environment for our
+community include:
 
 * Using welcoming and inclusive language
 * Being respectful of differing viewpoints and experiences
@@ -18,59 +25,102 @@ Examples of behavior that contributes to a positive environment for our communit
 
 Examples of unacceptable behavior include:
 
-* The use of sexualized language or imagery, and sexual attention or advances of any kind
+* The use of sexualized language or imagery, and sexual attention or advances
+  of any kind
 * Trolling, insulting or derogatory comments, and personal or political attacks
 * Public or private harassment
-* Publishing others' private information, such as a physical or email address, without their explicit permission
-* Other conduct which could reasonably be considered inappropriate in a professional setting
+* Publishing others' private information, such as a physical or email address,
+  without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
 
 ## Enforcement Responsibilities
 
-Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
+Community leaders are responsible for clarifying and enforcing our standards of
+acceptable behavior and will take appropriate and fair corrective action in
+response to any behavior that they deem inappropriate, threatening, offensive,
+or harmful.
 
-Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
+Community leaders have the right and responsibility to remove, edit, or reject
+comments, commits, code, wiki edits, issues, and other contributions that are
+not aligned to this Code of Conduct, and will communicate reasons for
+moderation decisions when appropriate.
 
 ## Scope
 
-This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
+This Code of Conduct applies within all community spaces, and also applies when
+an individual is officially representing the community in public spaces.
+Examples of representing our community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event.
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at [[email protected]](mailto:[email protected]). All complaints will be reviewed and investigated promptly and fairly.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported to the community leaders responsible for enforcement at
+[[email protected]](mailto:[email protected]). All
+complaints will be reviewed and investigated promptly and fairly.
 
-All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+All community leaders are obligated to respect the privacy and security of the
+reporter of any incident.
 
 ## Enforcement Guidelines
 
-Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+Community leaders will follow these Community Impact Guidelines in determining
+the consequences for any action they deem in violation of this Code of Conduct:
 
 ### 1. Correction
-**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
 
-**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+**Community Impact**: Use of inappropriate language or other behavior deemed
+unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing
+clarity around the nature of the violation and an explanation of why the
+behavior was inappropriate. A public apology may be requested.
 
 ### 2. Warning
+
 **Community Impact**: A violation through a single incident or series of actions.
 
-**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+**Consequence**: A warning with consequences for continued behavior. No
+interaction with the people involved, including unsolicited interaction with
+those enforcing the Code of Conduct, for a specified period of time. This
+includes avoiding interactions in community spaces as well as external channels
+like social media. Violating these terms may lead to a temporary or permanent
+ban.
 
 ### 3. Temporary Ban
-**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
 
-**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+**Community Impact**: A serious violation of community standards, including
+sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public
+communication with the community for a specified period of time. No public or
+private interaction with the people involved, including unsolicited interaction
+with those enforcing the Code of Conduct, is allowed during this period.
+Violating these terms may lead to a permanent ban.
 
 ### 4. Permanent Ban
-**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior, harassment of an individual, or aggression toward or disparagement of classes of individuals.
 
-**Consequence**: A permanent ban from any sort of public interaction within the community.
+**Community Impact**: Demonstrating a pattern of violation of community
+standards, including sustained inappropriate behavior, harassment of an
+individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within the
+community.
 
 ## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.1, available at [https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1].
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 2.1, available at
+[https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1].
 
-Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder][Mozilla CoC].
+Community Impact Guidelines were inspired by [Mozilla's code of conduct
+enforcement ladder][Mozilla CoC].
 
-For answers to common questions about this code of conduct, see the FAQ at [https://www.contributor-covenant.org/faq][FAQ]. Translations are available at [https://www.contributor-covenant.org/translations][translations].
+For answers to common questions about this code of conduct, see the FAQ at
+[https://www.contributor-covenant.org/faq][FAQ]. Translations are available at
+[https://www.contributor-covenant.org/translations][translations].
 
 [homepage]: https://www.contributor-covenant.org
 [v2.1]: https://www.contributor-covenant.org/version/2/1/code_of_conduct.html

CONTRIBUTING.md

@@ -1,10 +1,12 @@
 # Contributing to ContextForge Memory
 
-Thank you for your interest in contributing to ContextForge Memory! This document provides guidelines for contributing to the project.
+Thank you for your interest in contributing to ContextForge Memory! This
+document provides guidelines for contributing to the project.
 
 ## Code of Conduct
 
-This project adheres to our [Code of Conduct](CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code.
+This project adheres to our [Code of Conduct](CODE_OF_CONDUCT.md). By
+participating, you are expected to uphold this code.
 
 ## Getting Started
 
@@ -36,19 +38,22 @@ python -m pytest
 ### Branch Naming
 
 Use descriptive branch names:
+
 - `feature/add-new-endpoint`
 - `bugfix/fix-search-filtering`
 - `docs/update-readme`
 
 ### Commit Messages
 
 Write clear, descriptive commit messages:
+
 - Use present tense ("Add feature" not "Added feature")
 - Capitalize the first letter
 - No period at the end
 - Reference issues when applicable
 
 Examples:
+
 - `Add support for custom metadata validation`
 - `Fix search results ordering bug (#123)`
 - `Update API documentation`
@@ -58,11 +63,13 @@ Examples:
 ### Before Submitting
 
 1. **Run Tests**: Ensure all tests pass
+
    ```bash
    python -m pytest
    ```
 
 2. **Run Linting**: Fix any linting issues
+
    ```bash
    ruff check src
    black src
@@ -177,4 +184,5 @@ If you have questions about contributing, please:
 
 ## Thank You
 
-Thank you for contributing to ContextForge Memory! Your contributions help make this project better for everyone.
+Thank you for contributing to ContextForge Memory! Your contributions help make
+this project better for everyone.

README.md

@@ -1,32 +1,36 @@
-## ContextForge Memory (v0)
+# ContextForge Memory (v0)
 
-Lightweight external memory layer providing store, search, and embed APIs for multi-repo reuse (Brainstorm, Cursor, and others).
+Lightweight external memory layer providing store, search, and embed APIs for
+multi-repo reuse (Brainstorm, Cursor, and others).
+
+## Features
 
-### Features
 - Versioned API: `/v0/` with `store`, `search`, `embed`.
 - Deterministic, minimal embedding (hash-based) for baseline functionality.
 - Pluggable storage (default: JSONL on disk).
 
-### Quickstart
+## Quickstart
+
 ```bash
 python -m venv .venv && source .venv/bin/activate
 pip install -r requirements.txt
 uvicorn src.contextforge_memory.main:app --host 0.0.0.0 --port 8085
 ```
 
-### API Endpoints
+## API Endpoints
+
 - `GET /v0/health`
 - `POST /v0/store`
 - `POST /v0/search`
 - `POST /v0/embed`
 
 See `openapi/openapi-v0.yaml` for schemas.
 
-### Clients
+## Clients
+
 - Python: `clients/python/contextforge_client.py`
 - TypeScript: `clients/typescript/contextforgeClient.ts`
 
-### CI
-Basic import smoke in GitHub Actions (see `.github/workflows/ci.yml`).
-
+## CI
 
+Basic import smoke in GitHub Actions (see `.github/workflows/ci.yml`).

SECURITY.md

@@ -10,7 +10,9 @@ We currently support the following versions of ContextForge Memory:
 
 ## Reporting a Vulnerability
 
-We take security vulnerabilities seriously. If you discover a security vulnerability in ContextForge Memory, please report it to us as described below.
+We take security vulnerabilities seriously. If you discover a security
+vulnerability in ContextForge Memory, please report it to us as described
+below.
 
 ### How to Report
 
@@ -35,7 +37,8 @@ When reporting a vulnerability, please include:
 
 ### Security Updates
 
-Security updates will be released as patch versions (e.g., 0.1.1) and will be announced in the project's release notes.
+Security updates will be released as patch versions (e.g., 0.1.1) and will be
+announced in the project's release notes.
 
 ## Security Best Practices
 
@@ -49,4 +52,6 @@ When using ContextForge Memory:
 
 ## Acknowledgments
 
-We appreciate the security research community's efforts to help keep our software secure. We will acknowledge security researchers who responsibly disclose vulnerabilities to us.
+We appreciate the security research community's efforts to help keep our
+software secure. We will acknowledge security researchers who responsibly
+disclose vulnerabilities to us.

clients/python/contextforge_client.py

@@ -15,11 +15,15 @@ def health(self) -> Dict[str, Any]:
         return r.json()
 
     def store(self, items: List[Dict[str, Any]]) -> Dict[str, Any]:
-        r = self._client.post(f"{self.base_url}/v0/store", json={"items": items})
+        r = self._client.post(
+            f"{self.base_url}/v0/store", json={"items": items}
+        )
         r.raise_for_status()
         return r.json()
 
-    def search(self, namespace: str, project_id: str, query: str, top_k: int = 5) -> Dict[str, Any]:
+    def search(
+        self, namespace: str, project_id: str, query: str, top_k: int = 5
+    ) -> Dict[str, Any]:
         payload = {
             "namespace": namespace,
             "project_id": project_id,
@@ -31,8 +35,8 @@ def search(self, namespace: str, project_id: str, query: str, top_k: int = 5) ->
         return r.json()
 
     def embed(self, texts: List[str]) -> Dict[str, Any]:
-        r = self._client.post(f"{self.base_url}/v0/embed", json={"texts": texts})
+        r = self._client.post(
+            f"{self.base_url}/v0/embed", json={"texts": texts}
+        )
         r.raise_for_status()
         return r.json()
-
-

src/contextforge_memory/main.py

@@ -87,10 +87,8 @@ def search(req: SearchRequest) -> SearchResponse:
         return SearchResponse(results=results)
     query_vec = _embed_text(req.query)
 
-    def score(a: List[float], b: List[float]) -> float:
-        # Simple L2 distance inverted
-        return -sum((x - y) ** 2 for x, y in zip(a, b))
-
+    # Store items with their precomputed embeddings
+    items_with_embeddings: List[tuple[MemoryItem, List[float]]] = []
     with bucket.open("r", encoding="utf-8") as f:
         for line in f:
             data = orjson.loads(line)
@@ -99,12 +97,18 @@ def score(a: List[float], b: List[float]) -> float:
                 or data.get("project_id") != req.project_id
             ):
                 continue
-            results.append(MemoryItem(**data))
-
-    # Sort by score descending using precomputed query_vec
-    results.sort(
-        key=lambda it: -sum(
-            (x - y) ** 2 for x, y in zip(query_vec, _embed_text(it.text))
+            item = MemoryItem(**data)
+            # Compute embedding once during the initial loop
+            embedding = _embed_text(item.text)
+            items_with_embeddings.append((item, embedding))
+
+    # Sort by score descending using precomputed embeddings
+    items_with_embeddings.sort(
+        key=lambda item_embed: -sum(
+            (x - y) ** 2 for x, y in zip(query_vec, item_embed[1])
         )
     )
-    return SearchResponse(results=results[: max(1, req.top_k)])
+
+    # Extract just the MemoryItem objects for the response
+    results = [item for item, _ in items_with_embeddings[: max(1, req.top_k)]]
+    return SearchResponse(results=results)