Skip to content

Commit 08508fb

Browse files
authored
775 re add ump 3 (#776)
* Update Rider plugin * Bump version number * Migrate to unified Sensapex uMp * Bump Ephys Link * Version bump
1 parent 876ca45 commit 08508fb

File tree

6 files changed

+14
-25
lines changed

6 files changed

+14
-25
lines changed

Assets/Prefabs/UI/SettingsMenu/Menus/EphysLinkMenu.prefab

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -218,18 +218,12 @@ MonoBehaviour:
218218
m_MultiSelect: 0
219219
m_Options:
220220
m_Options:
221-
- m_Text: Sensapex uMp-4
222-
m_Image: {fileID: 0}
223-
m_Color: {r: 1, g: 1, b: 1, a: 1}
224-
- m_Text: Sensapex uMp-3
221+
- m_Text: Sensapex uMp
225222
m_Image: {fileID: 0}
226223
m_Color: {r: 1, g: 1, b: 1, a: 1}
227224
- m_Text: New Scale Pathfinder MPM Control v2.8.8+
228225
m_Image: {fileID: 0}
229226
m_Color: {r: 1, g: 1, b: 1, a: 1}
230-
- m_Text: New Scale M3-USB-3:1-EP
231-
m_Image: {fileID: 0}
232-
m_Color: {r: 1, g: 1, b: 1, a: 1}
233227
- m_Text: Local Server
234228
m_Image: {fileID: 0}
235229
m_Color: {r: 1, g: 1, b: 1, a: 1}
@@ -1581,7 +1575,7 @@ MonoBehaviour:
15811575
m_TargetGraphic: {fileID: 8665175951857608260}
15821576
m_HandleRect: {fileID: 2259807623879296756}
15831577
m_Direction: 2
1584-
m_Value: 1
1578+
m_Value: 0
15851579
m_Size: 1
15861580
m_NumberOfSteps: 0
15871581
m_OnValueChanged:
@@ -5943,7 +5937,7 @@ MonoBehaviour:
59435937
m_OnCullStateChanged:
59445938
m_PersistentCalls:
59455939
m_Calls: []
5946-
m_text: Sensapex uMp-4
5940+
m_text: Sensapex uMp
59475941
m_isRightToLeft: 0
59485942
m_fontAsset: {fileID: 11400000, guid: 8f586378b4e144a9851e7b34d9b748ee, type: 2}
59495943
m_sharedMaterial: {fileID: 2180264, guid: 8f586378b4e144a9851e7b34d9b748ee, type: 2}

Assets/Scripts/EphysLink/CommunicationManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class CommunicationManager : MonoBehaviour
2222

2323
#region Properties
2424

25-
private static readonly int[] EPHYS_LINK_MIN_VERSION = { 2, 0, 0 };
25+
private static readonly int[] EPHYS_LINK_MIN_VERSION = { 2, 1, 0 };
2626

2727
public static readonly string EPHYS_LINK_MIN_VERSION_STRING =
2828
$"≥ v{string.Join(".", EPHYS_LINK_MIN_VERSION)}";

Assets/Scripts/Pinpoint/UI/EphysLinkSettings/EphysLinkSettings.cs

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class EphysLinkSettings : MonoBehaviour
2020
{
2121
#region Constants
2222

23-
private const string EPHYS_LINK_NAME = "EphysLink-v2.0.2";
23+
private const string EPHYS_LINK_NAME = "EphysLink-v2.1.0b1";
2424

2525
private static string EphysLinkExePath =>
2626
Path.Combine(
@@ -109,15 +109,14 @@ private void OnDestroy()
109109

110110
public void OnTypeChanged(int type)
111111
{
112-
print("Type changed to " + type);
113112
// Show/hide extra groups based on connection type
114113
_existingServerGroup.SetActive(type == _manipulatorTypeDropdown.options.Count - 2);
115114
_proxyServerGroup.SetActive(type == _manipulatorTypeDropdown.options.Count - 1);
116115
_connectButton.SetActive(type >= _manipulatorTypeDropdown.options.Count - 2);
117116
_launchEphysLinkButton.gameObject.SetActive(
118117
type < _manipulatorTypeDropdown.options.Count - 2
119118
);
120-
_pathfinderPortInputField.gameObject.SetActive(type == 2);
119+
_pathfinderPortInputField.gameObject.SetActive(type == 1);
121120

122121
// Save settings
123122
Settings.EphysLinkManipulatorType = type;
@@ -225,14 +224,8 @@ var manipulatorPanel in _manipulatorIdToManipulatorConnectionSettingsPanel.Value
225224
/// </summary>
226225
public void OnLaunchEphysLinkPressed()
227226
{
228-
// Parse manipulator type string arg (invariant: custom connection should never happen).
229-
var manipulatorTypeString = _manipulatorTypeDropdown.value switch
230-
{
231-
1 => "ump-3",
232-
2 => "pathfinder-mpm",
233-
3 => "new-scale",
234-
_ => "ump-4"
235-
};
227+
// Parse manipulator type string arg.
228+
var manipulatorTypeString = _manipulatorTypeDropdown.value == 0 ? "ump" : "pathfinder-mpm";
236229

237230
// Make args string (ignore updates, select type).
238231
var args = $"-i -t {manipulatorTypeString}";

Packages/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"com.unity.addressables": "2.2.2",
44
"com.unity.ai.navigation": "2.0.5",
55
"com.unity.animation.rigging": "1.3.0",
6-
"com.unity.ide.rider": "3.0.35",
6+
"com.unity.ide.rider": "3.0.36",
77
"com.unity.ide.visualstudio": "2.0.22",
88
"com.unity.inputsystem": "1.11.2",
99
"com.unity.memoryprofiler": "1.1.1",

Packages/packages-lock.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"url": "https://packages.unity.com"
7272
},
7373
"com.unity.ide.rider": {
74-
"version": "3.0.35",
74+
"version": "3.0.36",
7575
"depth": 0,
7676
"source": "registry",
7777
"dependencies": {

ProjectSettings/ProjectSettings.asset

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ PlayerSettings:
4949
m_StereoRenderingPath: 0
5050
m_ActiveColorSpace: 0
5151
unsupportedMSAAFallback: 0
52+
m_SpriteBatchMaxVertexCount: 65535
5253
m_SpriteBatchVertexThreshold: 300
5354
m_MTRendering: 1
5455
mipStripping: 0
@@ -139,7 +140,7 @@ PlayerSettings:
139140
loadStoreDebugModeEnabled: 0
140141
visionOSBundleVersion: 1.0
141142
tvOSBundleVersion: 1.0
142-
bundleVersion: 2.0
143+
bundleVersion: 2.0.1b0
143144
preloadedAssets:
144145
- {fileID: 11400000, guid: 6057f25234ce83a4bbb3ae618a501907, type: 2}
145146
metroInputSource: 0
@@ -433,6 +434,7 @@ PlayerSettings:
433434
playModeTestRunnerEnabled: 0
434435
runPlayModeTestAsEditModeTest: 0
435436
actionOnDotNetUnhandledException: 1
437+
editorGfxJobOverride: 1
436438
enableInternalProfiler: 0
437439
logObjCUncaughtExceptions: 1
438440
enableCrashReportAPI: 0
@@ -742,7 +744,7 @@ PlayerSettings:
742744
apiCompatibilityLevelPerPlatform:
743745
Standalone: 3
744746
WebGL: 3
745-
editorAssembliesCompatibilityLevel: 1
747+
editorAssembliesCompatibilityLevel: 2
746748
m_RenderingPath: 1
747749
m_MobileRenderingPath: 1
748750
metroPackageName: Template3D

0 commit comments

Comments
 (0)