Skip to content

Commit 1ec2223

Browse files
committed
fix: adding some docs and fixing a bug in slicerenderer
1 parent a55e4b2 commit 1ec2223

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

Assets/Scripts/Pinpoint/Probes/ProbeManager.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,12 @@ public List<string> GetProbeDepthIDs()
458458
}
459459
return depthIDs;
460460
}
461-
461+
462+
/// <summary>
463+
/// Gets the probe anatomy in depth format (SpikeGLX)
464+
/// </summary>
465+
/// <param name="shank"></param>
466+
/// <returns></returns>
462467
private string perShankDepthIDs(int shank)
463468
{
464469
// Create a list of range, acronym color
@@ -524,6 +529,8 @@ private string perShankDepthIDs(int shank)
524529

525530
/// <summary>
526531
/// Get a serialized representation of the channel ID data
532+
///
533+
/// (OpenEphys format)
527534
/// </summary>
528535
/// <returns></returns>
529536
public string GetChannelAnnotationIDs(bool collapsed = true)

Assets/Scripts/Pinpoint/TP_SliceRenderer.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ public void UpdateSlicePosition()
8181
if (ProbeManager.ActiveProbeManager != null)
8282
(tipCoordWorld, _, _, _) = ProbeManager.ActiveProbeManager.ProbeController.GetTipWorldU();
8383

84+
Vector3 tipCoordWorldT = ProbeManager.ActiveProbeManager.ProbeController.ProbeTipT.position;
8485
// vertex order -x-y, +x-y, -x+y, +x+y
8586

8687
// compute the world vertex positions from the raw coordinates
@@ -89,8 +90,10 @@ public void UpdateSlicePosition()
8990
Vector3[] newSagittalVerts = new Vector3[4];
9091
for (int i = 0; i < _coronalOrigWorldU.Length; i++)
9192
{
92-
newCoronalVerts[i] = BrainAtlasManager.WorldU2WorldT(new Vector3(_coronalOrigWorldU[i].x, _coronalOrigWorldU[i].y, tipCoordWorld.z), false);
93-
newSagittalVerts[i] = BrainAtlasManager.WorldU2WorldT(new Vector3(tipCoordWorld.x, _sagittalOrigWorldU[i].y, _sagittalOrigWorldU[i].z), false);
93+
newCoronalVerts[i] = new Vector3(_coronalOrigWorldU[i].x, _coronalOrigWorldU[i].y, tipCoordWorldT.z);
94+
newSagittalVerts[i] = new Vector3(tipCoordWorldT.x, _sagittalOrigWorldU[i].y, _sagittalOrigWorldU[i].z);
95+
//newCoronalVerts[i] = BrainAtlasManager.WorldU2WorldT(new Vector3(_coronalOrigWorldU[i].x, _coronalOrigWorldU[i].y, tipCoordWorld.z), false);
96+
//newSagittalVerts[i] = BrainAtlasManager.WorldU2WorldT(new Vector3(tipCoordWorld.x, _sagittalOrigWorldU[i].y, _sagittalOrigWorldU[i].z), false);
9497
}
9598

9699
_coronalSliceGo.GetComponent<MeshFilter>().mesh.vertices = newCoronalVerts;

0 commit comments

Comments
 (0)