620 fix version reading logic (#623)

* Initial check logic

* Fixed dropdown colors

Author: kjy5

Assets/Scripts/EphysLink/CommunicationManager.cs

@@ -153,13 +153,33 @@ public void VerifyVersion(Action onSuccess, Action onFailure)
         {
             GetVersion(version =>
             {
-                if (!version.Split(".").Where((versionNumber, index) =>
-                            int.Parse(new string(versionNumber.TakeWhile(char.IsDigit).ToArray())) <
-                            EPHYS_LINK_MIN_VERSION[index])
-                        .Any())
-                    onSuccess.Invoke();
-                else
+                var versionNumbers = version.Split(".").Select(versionNumber =>
+                    int.Parse(new string(versionNumber.TakeWhile(char.IsDigit).ToArray()))).ToArray();
+                
+                // Fail if major version mismatch (breaking changes).
+                if (versionNumbers[0] != EPHYS_LINK_MIN_VERSION[0])
+                {
+                    onFailure.Invoke();
+                    return;
+                }
+
+                // Fail if minor version is too small (missing features).
+                if (versionNumbers[1] < EPHYS_LINK_MIN_VERSION[0])
+                {
                     onFailure.Invoke();
+                    return;
+                }
+
+                // Fail if patch version is too small and minor version is not greater (bug fixes).
+                if (versionNumbers[1] == EPHYS_LINK_MIN_VERSION[1] &&
+                    versionNumbers[2] < EPHYS_LINK_MIN_VERSION[2])
+                {
+                    onFailure.Invoke();
+                    return;
+                }
+                
+                // Passed checks.
+                onSuccess.Invoke();
             }, onFailure.Invoke);
         }
 

Assets/Scripts/Pinpoint/UI/EphysCopilot/InsertionOptionColorHandler.cs

@@ -22,13 +22,13 @@ private void Start()
             var textEndIndex = _text.text.LastIndexOf(": A", StringComparison.Ordinal);
             if (textEndIndex == -1) return;
 
-            // Get the probe manager with this UUID (if it exists)
+            // Get the probe manager with this UUID (if it exists).
             var probeNameString = _text.text[..textEndIndex];
             var matchingManager = InsertionSelectionPanelHandler.TargetableProbeManagers.First(manager =>
                 manager.name.Equals(probeNameString) || (manager.OverrideName?.Equals(probeNameString) ?? false));
             if (!matchingManager) return;
 
-            // Set the toggle color to match the probe color
+            // Get a copy of the toggle's color block.
             var colorBlockCopy = _toggle.colors;
             colorBlockCopy.normalColor = matchingManager.Color;
             colorBlockCopy.selectedColor = new Color(colorBlockCopy.normalColor.r * 0.9f,

Assets/Scripts/Pinpoint/UI/EphysCopilot/InsertionSelectionPanelHandler.cs

@@ -137,6 +137,13 @@ public void OnTargetInsertionDropdownValueChanged(int value)
                 _lineGameObjects.ap.SetActive(false);
                 _lineGameObjects.ml.SetActive(false);
                 _lineGameObjects.dv.SetActive(false);
+                
+                // Reset dropdown color.
+                var colorBlockCopy = _targetInsertionDropdown.colors;
+                colorBlockCopy.normalColor = new Color(1, 1, 1);
+                colorBlockCopy.selectedColor = new Color(0.8f, 0.8f, 0.8f);
+                colorBlockCopy.highlightedColor = colorBlockCopy.selectedColor;
+                _targetInsertionDropdown.colors = colorBlockCopy;
             }
             else
             {

Assets/Scripts/Pinpoint/UI/EphysLinkSettings/EphysLinkSettings.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using EphysLink;
 using TMPro;
-using TrajectoryPlanner.UI.EphysLinkSettings;
 using UnityEngine;
 using UnityEngine.Events;
 using UnityEngine.UI;

Assets/Scripts/Pinpoint/UI/EphysLinkSettings/ProbeOptionColorHandler.cs

@@ -1,7 +1,7 @@
 using UnityEngine;
 using UnityEngine.UI;
 
-namespace TrajectoryPlanner.UI.EphysLinkSettings
+namespace Pinpoint.UI.EphysLinkSettings
 {
     public class ProbeOptionColorHandler : MonoBehaviour
     {
@@ -14,11 +14,11 @@ public class ProbeOptionColorHandler : MonoBehaviour
 
         private void Start()
         {
-            // Get the probe manager with this UUID (if it exists)
+            // Get the probe manager with this UUID (if it exists).
             var matchingManager = ProbeManager.Instances.Find(manager => manager.UUID == _text.text);
             if (!matchingManager) return;
 
-            // Set the toggle color to match the probe color
+            // Get a copy of the toggle's color block.
             var colorBlockCopy = _toggle.colors;
             colorBlockCopy.normalColor = matchingManager.Color;
             colorBlockCopy.selectedColor = new Color(colorBlockCopy.normalColor.r * 0.9f,