Skip to content

Commit a65228f

Browse files
authored
393 add ump 3 (#455)
* Switch PyCharm to use hatch * Draft ump3 * Fixed uMp-3 set position * Begin transition to uMp binding * Add deprecation warning * Unified uMp * Fixed deprecation check
1 parent a624bf5 commit a65228f

File tree

6 files changed

+256
-162
lines changed

6 files changed

+256
-162
lines changed

.idea/ephys-link.iml

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/misc.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ephys_link/__about__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "2.0.2"
1+
__version__ = "2.1.0b0"

src/ephys_link/back_end/platform_handler.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,22 @@ def _get_binding_instance(self, options: EphysLinkOptions) -> BaseBinding:
7070
Returns:
7171
Bindings for the specified platform type.
7272
"""
73+
74+
# What the user supplied.
75+
selected_type = options.type
76+
7377
for binding_type in get_bindings():
7478
binding_cli_name = binding_type.get_cli_name()
7579

76-
if binding_cli_name == options.type:
80+
# Notify deprecation of "ump-4" and "ump-3" CLI options and fix.
81+
if selected_type in ("ump-4", "ump-3"):
82+
self._console.error_print(
83+
"DEPRECATION",
84+
f"CLI option '{selected_type}' is deprecated and will be removed in v3.0.0. Use 'ump' instead.",
85+
)
86+
selected_type = "ump"
87+
88+
if binding_cli_name == selected_type:
7789
# Pass in HTTP port for Pathfinder MPM.
7890
if binding_cli_name == "pathfinder-mpm":
7991
return MPMBinding(options.mpm_port)

src/ephys_link/bindings/ump_4_binding.py

Lines changed: 0 additions & 158 deletions
This file was deleted.

0 commit comments

Comments
 (0)