feat: static typing and safe builds (#63)

* Fixed typing in unity and vbl base

* Remaking build, moved unity to util

* Type safe schema build

* Draft generator, failing enums

* Correct build

* Fixed typing issues and rebuild

* Build models and static analysis

* Version bump, prep for 1.0

* Fixed CI

* Specify latest python

* Enable checkout and fetch on repo

* chore: Autoformat code

* Rename format commit message

* Add refs to enable workflow commit

* Fix some build spacing

---------

Co-authored-by: kjy5 <[email protected]>

Author: kjy5

.config/dotnet-tools.json

@@ -0,0 +1,12 @@
+{
+  "version": 1,
+  "isRoot": true,
+  "tools": {
+    "csharpier": {
+      "version": "0.30.3",
+      "commands": [
+        "dotnet-csharpier"
+      ]
+    }
+  }
+}

.github/dependabot.yml

@@ -13,6 +13,14 @@ updates:
       pip:
         patterns:
           - '*'
+  - package-ecosystem: "nuget" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"
+    groups:
+      pip:
+        patterns:
+          - '*'
   - package-ecosystem: "github-actions" # See documentation for possible values
     directory: ".github/workflows" # Location of package manifests
     schedule:

.github/workflows/build.yml .github/workflows/build-models.yml.github/workflows/build.yml renamed to .github/workflows/build-models.yml

@@ -1,4 +1,4 @@
-name: Build
+name: Build Models
 
 on:
   pull_request: 
@@ -14,20 +14,39 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
+        with:
+          ref: ${{ github.head_ref }}
+          token: ${{ secrets.WORKFLOW_COMMIT_TOKEN }}
 
       - name: 🐍 Setup Python
         uses: actions/setup-python@v5
         with:
           python-version: '3.x'
           cache: 'pip'
+        
+      - name: 🌐 Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 9
 
       - name: 📦 Install dependencies
-        run: pip install .
+        run: |
+          pip install .
+          dotnet tool restore
 
       - name: 🛠️ Build
         run: python src/vbl_aquarium/build.py
 
-      - name: 📤 PR changes
+      - name: 🧹 Format
+        run: dotnet csharpier models/csharp
+
+      - name: ✅ Commit code format changes (on PR)
+        if: github.ref != 'refs/heads/main'
+        uses: stefanzweifel/git-auto-commit-action@v5
+        with:
+          commit_message: "chore: Build Models"
+
+      - name: 📤 PR changes (on main)
         if: github.ref == 'refs/heads/main'
         uses: peter-evans/create-pull-request@v7
         with:

.github/workflows/autoformat-and-lint.yml .github/workflows/static-analysis.yml.github/workflows/autoformat-and-lint.yml renamed to .github/workflows/static-analysis.yml

@@ -1,4 +1,4 @@
-name: Autoformat and Lint
+name: Static Analysis
 
 on:
   pull_request:
@@ -7,8 +7,8 @@ on:
       - main
 
 jobs:
-  autoformat-and-lint:
-    name: Autoformat and Lint
+  analyze:
+    name: Analyze
     if: github.actor != 'dependabot[bot]'
     runs-on: ubuntu-latest
     permissions:
@@ -21,11 +21,17 @@ jobs:
           ref: ${{ github.head_ref }}
           token: ${{ secrets.WORKFLOW_COMMIT_TOKEN }}
 
+      - name: 🐍 Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.13'
+          cache: 'pip'
+
       - name: 🥚 Install Hatch
         uses: pypa/hatch@install
 
-      - name: 📝 Static Analysis
-        run: hatch fmt
+      - name: 📝 Format Code
+        run: hatch fmt -f
 
       - name: ✅ Commit code format changes
         if: github.ref != 'refs/heads/main'
@@ -43,4 +49,10 @@ jobs:
           commit-message: "chore: Autoformat code"
           title: "chore: Autoformat code"
           branch: "autoformat-code"
-          delete-branch: true
+          delete-branch: true
+
+      - name: 🧶 Lint
+        run: hatch fmt --check
+
+      - name: 🔍 Type Check
+        run: hatch run check

.idea/misc.xml

@@ -1,4 +1,5 @@
 using System;
+
 [Serializable]
 public struct BucketRequest
 {
@@ -104,4 +105,3 @@ public UploadRequest(int type, string data, string password)
         Password = password;
     }
 }
-

.idea/vbl-json-schema.iml

@@ -1,5 +1,5 @@
-using UnityEngine;
 using System;
+using UnityEngine;
 
 [Serializable]
 public struct AngularResponse
@@ -39,7 +39,16 @@ public struct EphysLinkOptions
     public int MpmPort;
     public string Serial;
 
-    public EphysLinkOptions(bool background, bool ignoreUpdates, string type, bool debug, bool useProxy, string proxyAddress, int mpmPort, string serial)
+    public EphysLinkOptions(
+        bool background,
+        bool ignoreUpdates,
+        string type,
+        bool debug,
+        bool useProxy,
+        string proxyAddress,
+        int mpmPort,
+        string serial
+    )
     {
         Background = background;
         IgnoreUpdates = ignoreUpdates;
@@ -52,7 +61,6 @@ public EphysLinkOptions(bool background, bool ignoreUpdates, string type, bool d
     }
 }
 
-
 [Serializable]
 public struct GetManipulatorsResponse
 {
@@ -61,7 +69,12 @@ public struct GetManipulatorsResponse
     public Vector4 Dimensions;
     public string Error;
 
-    public GetManipulatorsResponse(string[] manipulators, int numAxes, Vector4 dimensions, string error)
+    public GetManipulatorsResponse(
+        string[] manipulators,
+        int numAxes,
+        Vector4 dimensions,
+        string error
+    )
     {
         Manipulators = manipulators;
         NumAxes = numAxes;
@@ -70,7 +83,6 @@ public GetManipulatorsResponse(string[] manipulators, int numAxes, Vector4 dimen
     }
 }
 
-
 [Serializable]
 public struct PositionalResponse
 {
@@ -125,7 +137,6 @@ public SetInsideBrainRequest(string manipulatorId, bool inside)
     }
 }
 
-
 [Serializable]
 public struct SetPositionRequest
 {
@@ -153,4 +164,3 @@ public ShankCountResponse(int shankCount, string error)
         Error = error;
     }
 }
-

models/csharp/DockModels.cs

@@ -1,5 +1,6 @@
-using UnityEngine;
 using System;
+using UnityEngine;
+
 [Serializable]
 public struct BoolData
 {
@@ -26,7 +27,6 @@ public BoolList(string id, bool[] values)
     }
 }
 
-
 [Serializable]
 public struct ColorData
 {
@@ -40,7 +40,6 @@ public ColorData(string id, Color value)
     }
 }
 
-
 [Serializable]
 public struct ColorList
 {
@@ -128,7 +127,6 @@ public IDListBoolList(string[] iDs, bool[] values)
     }
 }
 
-
 [Serializable]
 public struct IDListColorData
 {
@@ -142,7 +140,6 @@ public IDListColorData(string[] iDs, Color value)
     }
 }
 
-
 [Serializable]
 public struct IDListColorList
 {
@@ -234,7 +231,6 @@ public IDListStringList(string[] iDs, string[] values)
     }
 }
 
-
 [Serializable]
 public struct IDListVector2Data
 {
@@ -248,7 +244,6 @@ public IDListVector2Data(string[] iDs, Vector2 value)
     }
 }
 
-
 [Serializable]
 public struct IDListVector2List
 {
@@ -262,7 +257,6 @@ public IDListVector2List(string[] iDs, Vector2[] values)
     }
 }
 
-
 [Serializable]
 public struct IDListVector3Data
 {
@@ -276,7 +270,6 @@ public IDListVector3Data(string[] iDs, Vector3 value)
     }
 }
 
-
 [Serializable]
 public struct IDListVector3List
 {
@@ -342,7 +335,6 @@ public StringList(string id, string[] values)
     }
 }
 
-
 [Serializable]
 public struct Vector2Data
 {
@@ -356,7 +348,6 @@ public Vector2Data(string id, Vector2 value)
     }
 }
 
-
 [Serializable]
 public struct Vector3Data
 {
@@ -370,7 +361,6 @@ public Vector3Data(string id, Vector3 value)
     }
 }
 
-
 [Serializable]
 public struct Vector3List
 {
@@ -383,4 +373,3 @@ public Vector3List(string id, Vector3[] values)
         Values = values;
     }
 }
-

models/csharp/EphysLinkModels.cs

@@ -1,4 +1,5 @@
 using System;
+
 [Serializable]
 public struct Log
 {
@@ -31,4 +32,3 @@ public LogWarning(string msg)
         Msg = msg;
     }
 }
-