Commit 9a76d44
committed
Faker: Ignore Num Lock state w/ popup key sequence
Referring to 4a75e02 (2.0 beta1) and
7dbdbdc (2.1), the VirtualGL Faker's
event handler historically matched both Mod1Mask and Mod2Mask in the
modifier state to an Alt key sequence in VGL_GUI. In the dawn of time
(AKA 2000 and late), that was correct, because Mod2Mask was used for the
right Alt key. In 2025, however, Mod2Mask is used for Num Lock, and
either Mod1Mask (Linux, FreeBSD) or Mod5Mask (Solaris 11) is used for
the right Alt key. Thus, the modifier state will always contain
Mod2Mask if Num Lock is on, so the event handler's previous logic never
matched fconfig.guimod in that case. Since we don't support Solaris
anymore and fconfig.guimod will only ever contain ShiftMask,
ControlMask, or Mod1Mask, the correct modern solution is to mask off all
other bits in the modifier state before comparing it to fconfig.guimod.1 parent 41c5789 commit 9a76d44
2 files changed
+7
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
674 | 674 | | |
675 | 675 | | |
676 | 676 | | |
677 | | - | |
678 | | - | |
679 | | - | |
680 | | - | |
681 | | - | |
682 | | - | |
| 677 | + | |
| 678 | + | |
683 | 679 | | |
684 | 680 | | |
685 | | - | |
686 | | - | |
| 681 | + | |
687 | 682 | | |
688 | 683 | | |
689 | 684 | | |
| |||
0 commit comments