fix: remove broken navigation item in bootstrap

Author: mateusz-kleszcz

package.json

@@ -1,6 +1,6 @@
 {
   "name": "strapi-plugin-navigation",
-  "version": "3.2.5",
+  "version": "3.2.6-beta.1",
   "description": "Strapi - Navigation plugin",
   "strapi": {
     "name": "navigation",

server/src/bootstrap.ts

@@ -4,9 +4,10 @@ import { configSetup } from './config';
 import { navigationSetup } from './i18n';
 import { setupPermissions } from './permissions';
 import { graphQLSetup } from './graphql';
-import { getPluginService } from './utils';
+import { getPluginService, removeNavigationsWithoutDefaultLocale } from './utils';
 
 const bootstrap = async (context: { strapi: Core.Strapi }) => {
+  await removeNavigationsWithoutDefaultLocale(context);
   await configSetup(context);
   await navigationSetup(context);
   await setupPermissions(context);

server/src/repositories/navigation.ts

@@ -101,13 +101,13 @@ export const getNavigationRepository = once((context: { strapi: Core.Strapi }) =
     }
   },
 
-  remove(navigation: Partial<Pick<NavigationDBSchema, 'documentId'>>) {
+  remove(navigation: Partial<Pick<NavigationDBSchema, 'documentId' | 'locale'>>) {
     const { masterModel } = getPluginModels(context);
 
     if (!navigation.documentId) {
       throw new NavigationError('Document id is required.');
     }
 
-    return context.strapi.documents(masterModel.uid).delete({ documentId: navigation.documentId });
+    return context.strapi.documents(masterModel.uid).delete({ documentId: navigation.documentId, locale: navigation.locale });
   },
 }));

server/src/services/admin/admin.ts

@@ -515,11 +515,12 @@ const adminService = (context: { strapi: Core.Strapi }) => ({
     });
     const allNavigations = await navigationRepository.find({
       filters: { documentId: navigation.documentId },
+      locale: '*',
       populate: '*',
     });
 
     await cleanNavigationItems(allNavigations.map(({ id }: NavigationDBSchema) => id));
-    await navigationRepository.remove({ documentId: navigation.documentId });
+    await navigationRepository.remove({ documentId: navigation.documentId, locale: '*' });
 
     sendAuditLog(auditLog, 'onNavigationDeletion', {
       entity: navigationAsDTO,

server/src/utils/index.ts

@@ -1,2 +1,3 @@
 export * from './constants';
 export * from './functions';
+export * from './migration';

server/src/utils/migration.ts

@@ -0,0 +1,13 @@
+import { Core } from "@strapi/types";
+import { getNavigationRepository } from "../repositories";
+
+export const removeNavigationsWithoutDefaultLocale = async (context: { strapi: Core.Strapi }) => {
+  const allNavigations = await getNavigationRepository(context).find({ locale: '*', limit: Number.MAX_SAFE_INTEGER });
+  const defaultLocale = context.strapi.plugin('i18n').service('locales').getDefaultLocale().code;
+  await Promise.all(allNavigations.map(async (navigation) => {
+    const root = allNavigations.find(({ documentId, locale }) => documentId === navigation.documentId && locale === defaultLocale);
+    if (!root) {
+      await getNavigationRepository(context).remove({ documentId: navigation.documentId, locale: navigation.locale });
+    }
+  }));
+}