Disambiguate --source command line option between CLI and compiler, favouring scalac meaning

Author: Gedochao

modules/cli/src/main/scala/scala/cli/commands/package0/PackageOptions.scala

@@ -51,8 +51,6 @@ final case class PackageOptions(
   @Name("sourcesJar")
   @Name("jarSources")
   @Name("sources")
-  @Name("source")
-  @Tag(tags.deprecated("source")) // alias to be removed in 1.6.x
   @Tag(tags.restricted)
   @Tag(tags.inShortHelp)
     src: Boolean = false,

modules/integration/src/test/scala/scala/cli/integration/BspTestDefinitions.scala

@@ -1712,7 +1712,7 @@ abstract class BspTestDefinitions extends ScalaCliSuite with TestScalaVersionArg
         "--power",
         "package",
         jarSources,
-        "--source",
+        "--src",
         "-o",
         sourceJarPath,
         extraOptions

modules/integration/src/test/scala/scala/cli/integration/PackageTestDefinitions.scala

@@ -859,16 +859,11 @@ abstract class PackageTestDefinitions extends ScalaCliSuite with TestScalaVersio
   test("source JAR") {
     val dest = os.rel / "sources.jar"
     simpleInputWithScalaAndSc.fromRoot { root =>
-      val r =
-        os.proc(TestUtil.cli, "--power", "package", extraOptions, ".", "-o", dest, "--source").call(
-          cwd = root,
-          stdin = os.Inherit,
-          stdout = os.Inherit,
-          stderr = os.Pipe
-        )
-      expect(r.err.trim().contains(
-        "The --source option alias has been deprecated and may be removed in a future version"
-      ))
+      os.proc(TestUtil.cli, "--power", "package", extraOptions, ".", "-o", dest, "--src").call(
+        cwd = root,
+        stdin = os.Inherit,
+        stdout = os.Inherit
+      )
 
       expect(os.isFile(root / dest))
 

website/docs/reference/cli-options.md

@@ -751,7 +751,7 @@ Generate a library JAR rather than an executable JAR
 
 ### `--src`
 
-Aliases: `--jar-sources`, [deprecated] `--source`, `--sources`, `--sources-jar`
+Aliases: `--jar-sources`, `--sources`, `--sources-jar`
 
 Generate a source JAR rather than an executable JAR