Skip to content

Commit 0425573

Browse files
authored
Merge pull request #2977 from Gedochao/maintenance/flaky-scalajs-native-docker-test
Tag flaky docker image with scala.js app test
2 parents acfcc17 + ca4d565 commit 0425573

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

modules/integration/src/test/scala/scala/cli/integration/NativePackagerTests.scala

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ import scala.util.Properties
66

77
class NativePackagerTests extends ScalaCliSuite {
88
override def group: ScalaCliSuite.TestGroup = ScalaCliSuite.TestGroup.First
9-
10-
val helloWorldFileName = "HelloWorldScalaCli.scala"
11-
val message = "Hello, world!"
12-
val licencePath = "DummyLICENSE"
9+
override def munitFlakyOK: Boolean = TestUtil.isCI
10+
val helloWorldFileName = "HelloWorldScalaCli.scala"
11+
val message = "Hello, world!"
12+
val licencePath = "DummyLICENSE"
1313
val testInputs: TestInputs = TestInputs(
1414
os.rel / helloWorldFileName ->
1515
s"""
@@ -415,7 +415,14 @@ class NativePackagerTests extends ScalaCliSuite {
415415
}
416416
}
417417

418-
test("building docker image with scala.js app") {
418+
// FIXME for some reason, this test became flaky on the CI
419+
if (TestUtil.isNativeCli)
420+
test("building docker image with scala.js app".flaky) {
421+
TestUtil.retryOnCi() {
422+
runJsTest()
423+
}
424+
}
425+
else test("building docker image with scala.js app") {
419426
TestUtil.retryOnCi() {
420427
runJsTest()
421428
}

modules/integration/src/test/scala/scala/cli/integration/ScalaCliSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ abstract class ScalaCliSuite extends munit.FunSuite {
2323
}
2424
}
2525

26-
override def munitTimeout: Duration = new FiniteDuration(120, TimeUnit.SECONDS)
26+
override def munitTimeout: Duration = new FiniteDuration(240, TimeUnit.SECONDS)
2727

2828
override def munitFixtures: List[Fixture[Unit]] = List(testStartEndLogger)
2929
def group: ScalaCliSuite.TestGroup = ScalaCliSuite.TestGroup.Third

0 commit comments

Comments
 (0)