Skip to content

Commit 155a03f

Browse files
committed
Restrict cmd options and clean up messages
- remove duplicated --cross option - gh-token share same message - add dome desctiptions
1 parent 860815e commit 155a03f

18 files changed

+37
-40
lines changed

modules/cli-options/src/main/scala/scala/cli/commands/AboutOptions.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ final case class AboutOptions(
1111
@Recurse
1212
verbosity: VerbosityOptions = VerbosityOptions(),
1313
@Hidden
14+
@HelpMessage(HelpMessages.passwordOption)
1415
ghToken: Option[PasswordOption] = None
1516
)
1617
// format: on

modules/cli-options/src/main/scala/scala/cli/commands/BenchmarkingOptions.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import caseapp._
55
// format: off
66
final case class BenchmarkingOptions(
77
@Group("Benchmarking")
8-
@HelpMessage("Run JMH benchmarks")
8+
@HelpMessage("[experimental] Run JMH benchmarks")
99
jmh: Option[Boolean] = None,
1010
@Group("Benchmarking")
11-
@HelpMessage("Set JMH version")
11+
@HelpMessage("[experimental] Set JMH version")
1212
@ValueDescription("version")
1313
jmhVersion: Option[String] = None
1414
)

modules/cli-options/src/main/scala/scala/cli/commands/CompileCrossOptions.scala

Lines changed: 0 additions & 17 deletions
This file was deleted.

modules/cli-options/src/main/scala/scala/cli/commands/CrossOptions.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import caseapp._
44

55
// format: off
66
final case class CrossOptions(
7+
@HelpMessage("[experimental] Run given command against all provided Scala versions and/or platforms")
78
cross: Option[Boolean] = None
89
)
910
// format: on

modules/cli-options/src/main/scala/scala/cli/commands/DependencyUpdateOptions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ final case class DependencyUpdateOptions(
99
@Recurse
1010
shared: SharedOptions = SharedOptions(),
1111
@Group("DependencyUpdate")
12-
@HelpMessage("Update all dependency")
12+
@HelpMessage("Update all dependencies if newer version was released")
1313
all: Boolean = false,
1414
)
1515
// format: on

modules/cli-options/src/main/scala/scala/cli/commands/DocOptions.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import caseapp._
44
import caseapp.core.help.Help
55

66
// format: off
7-
@HelpMessage("Generate Scaladoc documentation")
7+
@HelpMessage("Generate Scaladoc documentation", "By default, Scala CLI sets common scaladoc options and this mechanism can be disabled by using `--default-scaladoc-opts:false`.")
88
final case class DocOptions(
99
@Recurse
1010
shared: SharedOptions = SharedOptions(),
@@ -17,7 +17,7 @@ final case class DocOptions(
1717
@Name("f")
1818
force: Boolean = false,
1919
@Group("Doc")
20-
@HelpMessage("Use default scaladoc options")
20+
@HelpMessage("Control if scala CLI should use default options for scaladoc, true by default. Use `--default-scaladoc-opts:false` to not include default options.")
2121
@ExtraName("defaultScaladocOpts")
2222
defaultScaladocOptions: Option[Boolean] = None,
2323
)

modules/cli-options/src/main/scala/scala/cli/commands/DoctorOptions.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ final case class DoctorOptions(
1111
@Recurse
1212
verbosity: VerbosityOptions = VerbosityOptions(),
1313
@Hidden
14+
@HelpMessage(HelpMessages.passwordOption)
1415
ghToken: Option[PasswordOption] = None
1516
)
1617
// format: on

modules/cli-options/src/main/scala/scala/cli/commands/FmtOptions.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ final case class FmtOptions(
1313
check: Boolean = false,
1414

1515
@Group("Format")
16-
@HelpMessage("Use project filters defined in the configuration (turned on by default)")
16+
@HelpMessage("Use project filters defined in the configuration. Turned on by default, use `--respect-project-filters:false` to disable it.")
1717
respectProjectFilters: Boolean = true,
1818

1919
@Group("Format")
@@ -43,6 +43,7 @@ final case class FmtOptions(
4343

4444
@Group("Format")
4545
@Name("F")
46+
@HelpMessage("Pass argument to scalafmt.")
4647
scalafmtArg: List[String] = Nil,
4748

4849
@Group("Format")
@@ -55,7 +56,7 @@ final case class FmtOptions(
5556
@Name("scalafmtConfSnippet")
5657
scalafmtConfStr: Option[String] = None,
5758
@Group("Format")
58-
@HelpMessage("Pass a global dialect for scalafmt. This overrides whatever value is configured in the .scalafmt.conf file.")
59+
@HelpMessage("Pass a global dialect for scalafmt. This overrides whatever value is configured in the .scalafmt.conf file or inferred based on Scala version used.")
5960
@Name("dialect")
6061
scalafmtDialect: Option[String] = None,
6162
@Group("Format")
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package scala.cli.commands
2+
3+
object HelpMessages {
4+
val passwordOption = "A github token used to access GitHub. Not needed in most cases."
5+
}

modules/cli-options/src/main/scala/scala/cli/commands/PackageOptions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ final case class PackageOptions(
1313
@Recurse
1414
java: SharedJavaOptions = SharedJavaOptions(),
1515
@Recurse
16-
compileCross: CompileCrossOptions = CompileCrossOptions(),
16+
compileCross: CrossOptions = CrossOptions(),
1717
@Recurse
1818
mainClass: MainClassOptions = MainClassOptions(),
1919

0 commit comments

Comments
 (0)