Skip to content

Commit 1a65a0f

Browse files
Exceptions shouldn't be case classes
1 parent f6c8791 commit 1a65a0f

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

modules/build/src/main/scala/scala/build/preprocessing/directives/UsingScalaNativeOptionsDirectiveHandler.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ case object UsingScalaNativeOptionsDirectiveHandler extends UsingDirectiveHandle
7373
))
7474
res
7575
case "native-version" | "nativeVersion" =>
76-
Left(SingleValueExpected("native-version", scalaNativeOptions.map(_._1)))
76+
Left(new SingleValueExpected("native-version", scalaNativeOptions.map(_._1)))
7777
case "native-gc" | "nativeGc" =>
78-
Left(SingleValueExpected("native-gc", scalaNativeOptions.map(_._1)))
78+
Left(new SingleValueExpected("native-gc", scalaNativeOptions.map(_._1)))
7979
}
8080
intermediate.map { bo =>
8181
ProcessedDirective(Some(bo), Seq.empty)
@@ -84,6 +84,6 @@ case object UsingScalaNativeOptionsDirectiveHandler extends UsingDirectiveHandle
8484

8585
}
8686

87-
final case class SingleValueExpected(param: String, values: Seq[String]) extends BuildException(
87+
final class SingleValueExpected(param: String, values: Seq[String]) extends BuildException(
8888
s"Expected single value for $param but found $values"
8989
)

modules/build/src/test/scala/scala/build/tests/BuildTests.scala

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ class BuildTests extends munit.FunSuite {
628628
)
629629
inputs.withBuild(buildOptions, buildThreads, bloopConfig) { (_, _, maybeBuild) =>
630630
assert(maybeBuild.isLeft)
631-
assert(maybeBuild.left.get == SingleValueExpected("native-gc", Seq()))
631+
assert(maybeBuild.left.get == new SingleValueExpected("native-gc", Seq()))
632632
}
633633
}
634634

@@ -646,7 +646,7 @@ class BuildTests extends munit.FunSuite {
646646
)
647647
inputs.withBuild(buildOptions, buildThreads, bloopConfig) { (_, _, maybeBuild) =>
648648
assert(maybeBuild.isLeft)
649-
assert(maybeBuild.left.get == SingleValueExpected("native-gc", Seq("78", "12")))
649+
assert(maybeBuild.left.get == new SingleValueExpected("native-gc", Seq("78", "12")))
650650
}
651651

652652
}
@@ -683,7 +683,10 @@ class BuildTests extends munit.FunSuite {
683683
)
684684
inputs.withBuild(buildOptions, buildThreads, bloopConfig) { (_, _, maybeBuild) =>
685685
assert(maybeBuild.isLeft)
686-
assert(maybeBuild.left.get == SingleValueExpected("native-version", Seq("0.4.0", "0.3.3")))
686+
assert(maybeBuild.left.get == new SingleValueExpected(
687+
"native-version",
688+
Seq("0.4.0", "0.3.3")
689+
))
687690
}
688691

689692
}

0 commit comments

Comments
 (0)