Skip to content

Commit 1e65eb3

Browse files
committed
Bump alpine docker image to 3.16 & ensure it's used in tests
1 parent 08a547a commit 1e65eb3

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

build.sc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import $file.project.settings, settings.{
1818
projectFileName,
1919
jvmPropertiesFileName
2020
}
21-
import $file.project.deps, deps.customRepositories
21+
import $file.project.deps, deps.customRepositories, deps.alpineVersion
2222
import $file.project.website
2323

2424
import java.io.File
@@ -184,6 +184,7 @@ trait DocsTests extends CrossSbtModule with ScalaCliScalafixModule with HasTests
184184
| def coursierCliModule = "${Deps.coursierCli.dep.module.name.value}"
185185
| def coursierCliVersion = "${Deps.Versions.coursierCli}"
186186
| def defaultScalaVersion = "${Scala.defaultUser}"
187+
| def alpineVersion = "$alpineVersion"
187188
|}
188189
|""".stripMargin
189190
if (!os.isFile(dest) || os.read(dest) != code)
@@ -544,6 +545,8 @@ trait Core extends ScalaCliCrossSbtModule
544545
| def mavenAppVersion = "${Deps.Versions.mavenAppVersion}"
545546
|
546547
| def scalafixVersion = "${Deps.Versions.scalafix}"
548+
|
549+
| def alpineVersion = "$alpineVersion"
547550
|}
548551
|""".stripMargin
549552
if (!os.isFile(dest) || os.read(dest) != code)

modules/cli/src/main/scala/scala/cli/commands/github/LibSodiumJni.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,14 @@ object LibSodiumJni {
4040

4141
private def libsodiumVersion = Constants.libsodiumVersion
4242
private def libsodiumjniVersion = Constants.libsodiumjniVersion
43+
private def alpineVersion = Constants.alpineVersion
4344

4445
private def archiveUrlAndPath() =
4546
if (Properties.isLinux && launcherKindOpt.contains("static"))
4647
// Should actually be unused, as we statically link libsodium from the static launcher
4748
// Keeping it just-in-case. This could be useful from a musl-based JVM.
4849
(
49-
s"https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/libsodium-$libsodiumVersion-r0.apk",
50+
s"https://dl-cdn.alpinelinux.org/alpine/v$alpineVersion/main/x86_64/libsodium-$libsodiumVersion-r0.apk",
5051
os.rel / "usr" / "lib" / "libsodium.so.23.3.0" // FIXME Could this change?
5152
)
5253
else {

modules/docs-tests/src/test/scala/sclicheck/GifTests.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ class GifTests extends munit.FunSuite {
171171
ttyOpts,
172172
"-v",
173173
s"$out:/out",
174-
"alpine:3.16.2",
174+
s"alpine:${Constants.alpineVersion}",
175175
"sh",
176176
"-c",
177177
"rm -rf /out/* || true; rm -rf /out/.* || true"

project/deps.sc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -285,17 +285,16 @@ def buildCsM1Version = Deps.Versions.coursierM1Cli
285285
// Native library used to encrypt GitHub secrets
286286
def libsodiumVersion = "1.0.18"
287287
// Using the libsodium static library from this Alpine version (in the static launcher)
288-
def alpineVersion = "3.15"
288+
def alpineVersion = "3.16"
289289
def ubuntuVersion = "24.04"
290290

291291
object Docker {
292292
def customMuslBuilderImageName = "scala-cli-base-musl"
293293
def muslBuilder =
294294
s"$customMuslBuilderImageName:latest"
295295

296-
def testImage = s"ubuntu:$ubuntuVersion"
297-
def alpineTestImage =
298-
"alpine@sha256:4edbd2beb5f78b1014028f4fbb99f3237d9561100b6881aabbf5acce2c4f9454"
296+
def testImage = s"ubuntu:$ubuntuVersion"
297+
def alpineTestImage = s"alpine:$alpineVersion"
299298
def authProxyTestImage =
300299
"bahamat/authenticated-proxy@sha256:568c759ac687f93d606866fbb397f39fe1350187b95e648376b971e9d7596e75"
301300
}

project/settings.sc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ trait CliLaunchers extends SbtModule { self =>
242242
cs,
243243
"get",
244244
"--archive",
245-
"https://download.libsodium.org/libsodium/releases/libsodium-1.0.18-stable-msvc.zip"
245+
s"https://download.libsodium.org/libsodium/releases/libsodium-$libsodiumVersion-stable-msvc.zip"
246246
).call()
247247
val dir = os.Path(dirRes.out.trim(), os.pwd)
248248
os.copy.over(

0 commit comments

Comments
 (0)