Skip to content

Commit 36d5354

Browse files
Update munit to 1.0.0 (#2935)
* Update munit to 1.0.0 * Increase test suites' `munitTimeout` to 120s * Adjust tests to use the latest `munit` * Increase `munitTimeout` for `doc-tests` * Increase `munitTimeout` for `GifTests` & `RunDockerTests` --------- Co-authored-by: Piotr Chabelski <[email protected]>
1 parent d7311e9 commit 36d5354

File tree

9 files changed

+27
-4
lines changed

9 files changed

+27
-4
lines changed

modules/build/src/test/scala/scala/build/tests/BuildTests.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ abstract class BuildTests(server: Boolean) extends TestUtil.ScalaCliBuildSuite {
596596

597597
test("cli dependency options shadowing using directives") {
598598
val usingDependency = "org.scalameta::munit::1.0.0-M1"
599-
val cliDependency = "org.scalameta::munit::0.7.29"
599+
val cliDependency = "org.scalameta::munit::1.0.0"
600600

601601
val inputs = TestInputs(
602602
os.rel / "foo.scala" ->

modules/build/src/test/scala/scala/build/tests/TestUtil.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,12 @@ import scala.build.{Build, Positioned}
44
import scala.build.options.{BuildOptions, Platform}
55
import munit.Assertions.assertEquals
66

7+
import java.util.concurrent.TimeUnit
8+
import scala.concurrent.duration.FiniteDuration
9+
710
object TestUtil {
811
abstract class ScalaCliBuildSuite extends munit.FunSuite {
12+
override def munitTimeout = new FiniteDuration(120, TimeUnit.SECONDS)
913
val testStartEndLogger = new Fixture[Unit]("files") {
1014
def apply(): Unit = ()
1115

modules/docs-tests/src/test/scala/sclicheck/DocTests.scala

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
package sclicheck
22

3+
import java.util.concurrent.TimeUnit
4+
5+
import scala.concurrent.duration.FiniteDuration
6+
37
class DocTests extends munit.FunSuite {
8+
override def munitTimeout = new FiniteDuration(240, TimeUnit.SECONDS)
49
case class DocTestEntry(name: String, path: os.Path, depth: Int = Int.MaxValue)
510

611
val docsRootPath: os.Path = os.pwd / "website" / "docs"

modules/docs-tests/src/test/scala/sclicheck/GifTests.scala

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
package sclicheck
22

3+
import java.util.concurrent.TimeUnit
4+
5+
import scala.concurrent.duration.FiniteDuration
6+
37
class GifTests extends munit.FunSuite {
8+
override def munitTimeout = new FiniteDuration(360, TimeUnit.SECONDS)
49

510
val scenariosDir =
611
Option(System.getenv("SCALA_CLI_GIF_SCENARIOS")).map(os.Path(_, os.pwd)).getOrElse {

modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import caseapp.core.Arg
55
import caseapp.core.Scala3Helpers.*
66
import caseapp.core.util.Formatter
77
import dotty.tools.dotc.ScalacCommand
8-
import munit.internal.difflib.Diff
8+
import munit.diff.Diff
99
import shapeless.tag
1010

1111
import java.nio.charset.StandardCharsets

modules/integration/docker/src/test/scala/scala/cli/integration/RunDockerTests.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@ import com.eed3si9n.expecty.Expecty.expect
44

55
import java.io.ByteArrayOutputStream
66
import java.nio.charset.Charset
7+
import java.util.concurrent.TimeUnit
8+
import scala.concurrent.duration.{Duration, FiniteDuration}
79

810
class RunDockerTests extends munit.FunSuite {
11+
override def munitTimeout: Duration = new FiniteDuration(240, TimeUnit.SECONDS)
912

1013
lazy val imageName = Option(System.getenv("SCALA_CLI_IMAGE")).getOrElse {
1114
sys.error("SCALA_CLI_IMAGE not set")

modules/integration/src/test/scala/scala/cli/integration/ScalaCliSuite.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
package scala.cli.integration
22

3+
import java.util.concurrent.TimeUnit
4+
5+
import scala.concurrent.duration.{Duration, FiniteDuration}
6+
37
abstract class ScalaCliSuite extends munit.FunSuite {
48
val testStartEndLogger = new Fixture[Unit]("files") {
59
def apply(): Unit = ()
@@ -19,6 +23,8 @@ abstract class ScalaCliSuite extends munit.FunSuite {
1923
}
2024
}
2125

26+
override def munitTimeout: Duration = new FiniteDuration(120, TimeUnit.SECONDS)
27+
2228
override def munitFixtures: List[Fixture[Unit]] = List(testStartEndLogger)
2329
def group: ScalaCliSuite.TestGroup = ScalaCliSuite.TestGroup.Third
2430

modules/integration/src/test/scala/scala/cli/integration/TestTestDefinitions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package scala.cli.integration
33
import com.eed3si9n.expecty.Expecty.expect
44

55
import scala.annotation.tailrec
6+
import scala.cli.integration.Constants.munitVersion
67

78
abstract class TestTestDefinitions extends ScalaCliSuite with TestScalaVersionArgs {
89
_: TestScalaVersion =>
@@ -13,7 +14,6 @@ abstract class TestTestDefinitions extends ScalaCliSuite with TestScalaVersionAr
1314
protected lazy val baseExtraOptions: Seq[String] = TestUtil.extraOptions ++ jvmOptions
1415
private lazy val extraOptions: Seq[String] = scalaVersionArgs ++ baseExtraOptions
1516

16-
private val munitVersion = "1.0.0-M12"
1717
private val utestVersion = "0.8.3"
1818

1919
def successfulTestInputs(directivesString: String =

project/deps.sc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ object Deps {
157157
def metaconfigTypesafe =
158158
ivy"com.geirsson::metaconfig-typesafe-config:0.12.0"
159159
.exclude(("org.scala-lang", "scala-compiler"))
160-
def munit = ivy"org.scalameta::munit:0.7.29"
160+
def munit = ivy"org.scalameta::munit:1.0.0"
161161
def nativeTestRunner = ivy"org.scala-native::test-runner:${Versions.scalaNative}"
162162
def nativeTools = ivy"org.scala-native::tools:${Versions.scalaNative}"
163163
def osLib = ivy"com.lihaoyi::os-lib:0.10.2"

0 commit comments

Comments
 (0)