Skip to content

Commit 3aa4b87

Browse files
committed
Warn about --test not doing anything in dependency update
1 parent c583bd5 commit 3aa4b87

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

modules/cli/src/main/scala/scala/cli/commands/dependencyupdate/DependencyUpdate.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import caseapp.core.help.HelpFormat
55

66
import scala.build.actionable.ActionableDependencyHandler
77
import scala.build.actionable.ActionableDiagnostic.ActionableDependencyUpdateDiagnostic
8+
import scala.build.internals.ConsoleUtils.ScalaCliConsole.warnPrefix
89
import scala.build.options.{BuildOptions, Scope}
910
import scala.build.{CrossSources, Logger, Position, Sources}
1011
import scala.cli.CurrentParams
@@ -24,6 +25,11 @@ object DependencyUpdate extends ScalaCommand[DependencyUpdateOptions] {
2425
args: RemainingArgs,
2526
logger: Logger
2627
): Unit = {
28+
if options.scope.test then
29+
logger.message(
30+
s"""$warnPrefix Including the test scope does not change the behaviour of this command.
31+
|$warnPrefix Test dependencies are updated regardless.""".stripMargin
32+
)
2733
val verbosity = options.shared.logging.verbosity
2834
val buildOptions = buildOptionsOrExit(options)
2935

modules/cli/src/main/scala/scala/cli/commands/dependencyupdate/DependencyUpdateOptions.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package scala.cli.commands.dependencyupdate
33
import caseapp.*
44
import caseapp.core.help.Help
55

6-
import scala.cli.commands.shared.{HasSharedOptions, HelpGroup, SharedOptions}
6+
import scala.cli.commands.shared.{HasSharedOptions, HelpGroup, ScopeOptions, SharedOptions}
77
import scala.cli.commands.tags
88

99
// format: off
@@ -16,6 +16,8 @@ final case class DependencyUpdateOptions(
1616
@Tag(tags.restricted)
1717
@Tag(tags.inShortHelp)
1818
all: Boolean = false,
19+
@Recurse
20+
scope: ScopeOptions = ScopeOptions()
1921
) extends HasSharedOptions
2022
// format: on
2123

modules/core/src/main/scala/scala/build/internals/ConsoleUtils.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ object ConsoleUtils {
44
import Console.*
55

66
object ScalaCliConsole {
7-
val GRAY: String = "\u001b[90m"
7+
lazy val warnPrefix = s"[${YELLOW}warn$RESET]"
8+
val GRAY: String = "\u001b[90m"
89
}
910

1011
val ansiFormattingKeys: Set[String] = Set(RESET, BOLD, UNDERLINED, REVERSED, INVISIBLE)

website/docs/reference/cli-options.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1534,7 +1534,7 @@ Run scalafix rule(s) explicitly, overriding the configuration file default.
15341534

15351535
Available in commands:
15361536

1537-
[`compile`](./commands.md#compile), [`doc`](./commands.md#doc), [`export`](./commands.md#export), [`package`](./commands.md#package), [`publish`](./commands.md#publish), [`publish local`](./commands.md#publish-local), [`repl` , `console`](./commands.md#repl), [`run`](./commands.md#run), [`shebang`](./commands.md#shebang)
1537+
[`compile`](./commands.md#compile), [`dependency-update`](./commands.md#dependency-update), [`doc`](./commands.md#doc), [`export`](./commands.md#export), [`package`](./commands.md#package), [`publish`](./commands.md#publish), [`publish local`](./commands.md#publish-local), [`repl` , `console`](./commands.md#repl), [`run`](./commands.md#run), [`shebang`](./commands.md#shebang)
15381538

15391539
<!-- Automatically generated, DO NOT EDIT MANUALLY -->
15401540

website/docs/reference/commands.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Accepts option groups: [config](./cli-options.md#config-options), [coursier](./c
8080

8181
Update dependency directives in the project
8282

83-
Accepts option groups: [benchmarking](./cli-options.md#benchmarking-options), [compilation server](./cli-options.md#compilation-server-options), [coursier](./cli-options.md#coursier-options), [debug](./cli-options.md#debug-options), [dependency](./cli-options.md#dependency-options), [dependency update](./cli-options.md#dependency-update-options), [global suppress warning](./cli-options.md#global-suppress-warning-options), [help group](./cli-options.md#help-group-options), [input](./cli-options.md#input-options), [jvm](./cli-options.md#jvm-options), [logging](./cli-options.md#logging-options), [markdown](./cli-options.md#markdown-options), [power](./cli-options.md#power-options), [python](./cli-options.md#python-options), [Scala.js](./cli-options.md#scalajs-options), [Scala Native](./cli-options.md#scala-native-options), [scalac](./cli-options.md#scalac-options), [scalac extra](./cli-options.md#scalac-extra-options), [semantic db](./cli-options.md#semantic-db-options), [shared](./cli-options.md#shared-options), [snippet](./cli-options.md#snippet-options), [source generator](./cli-options.md#source-generator-options), [suppress warning](./cli-options.md#suppress-warning-options), [verbosity](./cli-options.md#verbosity-options), [version](./cli-options.md#version-options), [workspace](./cli-options.md#workspace-options)
83+
Accepts option groups: [benchmarking](./cli-options.md#benchmarking-options), [compilation server](./cli-options.md#compilation-server-options), [coursier](./cli-options.md#coursier-options), [debug](./cli-options.md#debug-options), [dependency](./cli-options.md#dependency-options), [dependency update](./cli-options.md#dependency-update-options), [global suppress warning](./cli-options.md#global-suppress-warning-options), [help group](./cli-options.md#help-group-options), [input](./cli-options.md#input-options), [jvm](./cli-options.md#jvm-options), [logging](./cli-options.md#logging-options), [markdown](./cli-options.md#markdown-options), [power](./cli-options.md#power-options), [python](./cli-options.md#python-options), [Scala.js](./cli-options.md#scalajs-options), [Scala Native](./cli-options.md#scala-native-options), [scalac](./cli-options.md#scalac-options), [scalac extra](./cli-options.md#scalac-extra-options), [scope](./cli-options.md#scope-options), [semantic db](./cli-options.md#semantic-db-options), [shared](./cli-options.md#shared-options), [snippet](./cli-options.md#snippet-options), [source generator](./cli-options.md#source-generator-options), [suppress warning](./cli-options.md#suppress-warning-options), [verbosity](./cli-options.md#verbosity-options), [version](./cli-options.md#version-options), [workspace](./cli-options.md#workspace-options)
8484

8585
## doc
8686

0 commit comments

Comments
 (0)