Vcs.parse fix (#1963)

* Vcs.parse fix: split by char instead of (malformed) regex

* VcsParseTest

* move VcsParseTest to modules/build (see #1976)

* VcsParseTest fix

* Vcs.parse: fix github parsing

Author: KuceraMartin

modules/build/src/test/scala/scala/build/options/publish/VcsParseTest.scala

@@ -0,0 +1,91 @@
+package scala.build.options.publish
+
+import scala.build.Positioned
+import scala.build.errors.{BuildException, MalformedInputError}
+
+import munit.Assertions.assertEquals
+
+class VcsParseTest extends munit.FunSuite {
+  test("valid GitHub") {
+    val actual = Vcs.parse(Positioned.none("github:VirtusLab/scala-cli"))
+    val expected: Either[BuildException, Vcs] = Right(Vcs(
+      "https://github.com/VirtusLab/scala-cli.git",
+      "scm:git:github.com/VirtusLab/scala-cli.git",
+      "scm:git:[email protected]:VirtusLab/scala-cli.git"
+    ))
+
+    assertEquals(expected, actual)
+  }
+
+  test("invalid GitHub: missing /") {
+    val actual = Vcs.parse(Positioned.none("github:scala-cli"))
+    val expected =
+      Left(new MalformedInputError("github-vcs", "github:scala-cli", "github:org/project", Nil))
+
+    assert(actual.isInstanceOf[Left[BuildException, Vcs]])
+    assertEquals(expected.toString, actual.toString)
+  }
+
+  test("invalid GitHub: too many /") {
+    val actual = Vcs.parse(Positioned.none("github:github.com/VirtusLab/scala-cli"))
+    val expected = Left(new MalformedInputError(
+      "github-vcs",
+      "github:github.com/VirtusLab/scala-cli",
+      "github:org/project",
+      Nil
+    ))
+
+    assert(actual.isInstanceOf[Left[BuildException, Vcs]])
+    assertEquals(expected.toString, actual.toString)
+  }
+
+  test("valid generic") {
+    val actual = Vcs.parse(Positioned.none(
+      "https://github.com/VirtusLab/scala-cli.git|scm:git:github.com/VirtusLab/scala-cli.git|scm:git:[email protected]:VirtusLab/scala-cli.git"
+    ))
+    val expected: Either[BuildException, Vcs] = Right(Vcs(
+      "https://github.com/VirtusLab/scala-cli.git",
+      "scm:git:github.com/VirtusLab/scala-cli.git",
+      "scm:git:[email protected]:VirtusLab/scala-cli.git"
+    ))
+
+    assertEquals(expected, actual)
+  }
+
+  test("invalid generic: missing |") {
+    val actual = Vcs.parse(Positioned.none(
+      "https://github.com/VirtusLab/scala-cli|scm:git:github.com/VirtusLab/scala-cli.git"
+    ))
+    val expected = Left(new MalformedInputError(
+      "vcs",
+      "https://github.com/VirtusLab/scala-cli|scm:git:github.com/VirtusLab/scala-cli.git",
+      "url|connection|developer-connection",
+      Nil
+    ))
+
+    assert(actual.isInstanceOf[Left[BuildException, Vcs]])
+    assertEquals(expected.toString, actual.toString)
+  }
+
+  test("invalid generic: extra |") {
+    val actual = Vcs.parse(Positioned.none("a|b|c|d"))
+    val expected =
+      Left(new MalformedInputError("vcs", "a|b|c|d", "url|connection|developer-connection", Nil))
+
+    assert(actual.isInstanceOf[Left[BuildException, Vcs]])
+    assertEquals(expected.toString, actual.toString)
+  }
+
+  test("invalid generic: gibberish") {
+    val actual = Vcs.parse(Positioned.none("sfrgt pagdhn"))
+    val expected = Left(new MalformedInputError(
+      "vcs",
+      "sfrgt pagdhn",
+      "url|connection|developer-connection",
+      Nil
+    ))
+
+    assert(actual.isInstanceOf[Left[BuildException, Vcs]])
+    assertEquals(expected.toString, actual.toString)
+  }
+}

modules/options/src/main/scala/scala/build/options/publish/Vcs.scala

@@ -13,7 +13,7 @@ object Vcs {
 
   def parse(input: Positioned[String]): Either[BuildException, Vcs] =
     if (input.value.startsWith("github:"))
-      input.value.stripPrefix("github:").split("/", 2) match {
+      input.value.stripPrefix("github:").split('/') match {
         case Array(org, project) =>
           val vcs = Vcs(
             s"https://github.com/$org/$project.git",
@@ -32,7 +32,7 @@ object Vcs {
           )
       }
     else
-      input.value.split("|", 3) match {
+      input.value.split('|') match {
         case Array(url, conn, devConn) =>
           val vcs = Vcs(url, conn, devConn)
           Right(vcs)