Fix default scaladoc config, so that id doesn't break all scaladoc links (#3041)

* Fix default scaladoc config, so that id doesn't break all scaladoc links

Right now running the doc command with default arguments in scala-cli
always produced broken scaladoc links, because the default regex for
external mappings mapped every tasty file that contained 'scala' to use
the `scala-lang.org` mapping. And since scala-cli uses '.scala-build'
directory for placing tasty files, almost all links were broken.

* Add an integration test to check if scaladoc correctly links local members to local links

Author: KacperFKorban

build.sc

@@ -116,7 +116,8 @@ object `scala-cli-bsp` extends JavaModule with ScalaCliPublishModule {
 object integration extends CliIntegration {
   object test extends IntegrationScalaTests {
     def ivyDeps = super.ivyDeps() ++ Seq(
-      Deps.jgit
+      Deps.jgit,
+      Deps.jsoup
     )
   }
   object docker extends CliIntegrationDocker {

modules/cli/src/main/scala/scala/cli/commands/doc/Doc.scala

@@ -125,8 +125,8 @@ object Doc extends ScalaCommand[DocOptions] {
     "-snippet-compiler:compile",
     "-Ygenerate-inkuire",
     "-external-mappings:" +
-      ".*scala.*::scaladoc3::https://scala-lang.org/api/3.x/," +
-      ".*java.*::javadoc::https://docs.oracle.com/javase/8/docs/api/",
+      ".*/scala/.*::scaladoc3::https://scala-lang.org/api/3.x/," +
+      ".*/java/.*::javadoc::https://docs.oracle.com/javase/8/docs/api/",
     "-author",
     "-groups"
   )

modules/integration/src/test/scala/scala/cli/integration/DocTestDefinitions.scala

@@ -1,6 +1,9 @@
 package scala.cli.integration
 
 import com.eed3si9n.expecty.Expecty.expect
+import org.jsoup._
+
+import scala.jdk.CollectionConverters._
 
 abstract class DocTestDefinitions extends ScalaCliSuite with TestScalaVersionArgs {
   _: TestScalaVersion =>
@@ -55,8 +58,16 @@ abstract class DocTestDefinitions extends ScalaCliSuite with TestScalaVersionArg
             "lib/Messages$.html"
           )
       val entries =
-        os.walk(root / dest).map(_.relativeTo(expectedDestDocPath)).map(_.toString()).toList
+        os.walk(root / dest).filter(!os.isDir(_)).map { path =>
+          path.relativeTo(expectedDestDocPath).toString() -> os.read(path)
+        }.toMap
       expect(expectedEntries.forall(e => entries.contains(e)))
+
+      val documentableNameElement =
+        Jsoup.parse(entries("index.html")).select(".documentableName").asScala
+      documentableNameElement.filter(_.text().contains("lib")).foreach { element =>
+        expect(!element.attr("href").startsWith("http"))
+      }
     }
   }
 }

project/deps.sc

@@ -97,6 +97,7 @@ object Deps {
     def coursierM1Cli                     = coursierDefault
     def jsoniterScala                     = "2.23.2"
     def jsoniterScalaJava8                = "2.13.5.2"
+    def jsoup                             = "1.18.1"
     def scalaMeta                         = "4.9.8"
     def scalaNative04                     = "0.4.17"
     def scalaNative05                     = "0.5.4"
@@ -156,6 +157,7 @@ object Deps {
     ivy"com.github.plokhotnyuk.jsoniter-scala::jsoniter-scala-macros:${Versions.jsoniterScalaJava8}"
   def jsoniterMacrosJava8 =
     ivy"com.github.plokhotnyuk.jsoniter-scala::jsoniter-scala-macros:${Versions.jsoniterScalaJava8}"
+  def jsoup         = ivy"org.jsoup:jsoup:${Versions.jsoup}"
   def libsodiumjni  = ivy"org.virtuslab.scala-cli:libsodiumjni:0.0.4"
   def macroParadise = ivy"org.scalamacros:::paradise:2.1.1"
   def metaconfigTypesafe =