chore: make --test an Option[Boolean]

Author: Gedochao

modules/cli/src/main/scala/scala/cli/commands/compile/Compile.scala

@@ -102,6 +102,7 @@ object Compile extends ScalaCommand[CompileOptions] with BuildCommandHelpers {
         configDb.get(Keys.actions).getOrElse(None)
       )
 
+    val shouldBuildTestScope = options.shared.scope.test.getOrElse(false)
     if (options.watch.watchMode) {
       val watcher = Build.watch(
         inputs,
@@ -110,7 +111,7 @@ object Compile extends ScalaCommand[CompileOptions] with BuildCommandHelpers {
         None,
         logger,
         crossBuilds = cross,
-        buildTests = options.shared.scope.test,
+        buildTests = shouldBuildTestScope,
         partial = None,
         actionableDiagnostics = actionableDiagnostics,
         postAction = () => WatchUtil.printWatchMessage()
@@ -129,7 +130,7 @@ object Compile extends ScalaCommand[CompileOptions] with BuildCommandHelpers {
         None,
         logger,
         crossBuilds = cross,
-        buildTests = options.shared.scope.test,
+        buildTests = shouldBuildTestScope,
         partial = None,
         actionableDiagnostics = actionableDiagnostics
       )

modules/cli/src/main/scala/scala/cli/commands/dependencyupdate/DependencyUpdate.scala

@@ -25,7 +25,7 @@ object DependencyUpdate extends ScalaCommand[DependencyUpdateOptions] {
     args: RemainingArgs,
     logger: Logger
   ): Unit = {
-    if options.shared.scope.test then
+    if options.shared.scope.test.nonEmpty then
       logger.message(
         s"""$warnPrefix Including the test scope does not change the behaviour of this command. 
            |$warnPrefix Test dependencies are updated regardless.""".stripMargin

modules/cli/src/main/scala/scala/cli/commands/doc/Doc.scala

@@ -52,7 +52,7 @@ object Doc extends ScalaCommand[DocOptions] {
         configDb.get(Keys.actions).getOrElse(None)
       )
 
-    val withTestScope = options.shared.scope.test
+    val withTestScope = options.shared.scope.test.getOrElse(false)
     Build.build(
       inputs,
       initialBuildOptions,

modules/cli/src/main/scala/scala/cli/commands/export0/Export.scala

@@ -136,7 +136,7 @@ object Export extends ScalaCommand[ExportOptions] {
   override def sharedOptions(opts: ExportOptions): Option[SharedOptions] = Some(opts.shared)
 
   override def runCommand(options: ExportOptions, args: RemainingArgs, logger: Logger): Unit = {
-    if options.shared.scope.test then {
+    if options.shared.scope.test.nonEmpty then {
       logger.error(
         s"""Including the test scope sources together with the main scope is currently not supported.
            |Note that test scope sources will still be exported as per the output build tool tests definition demands.""".stripMargin

modules/cli/src/main/scala/scala/cli/commands/fmt/Fmt.scala

@@ -43,7 +43,7 @@ object Fmt extends ScalaCommand[FmtOptions] {
   override def runCommand(options: FmtOptions, args: RemainingArgs, logger: Logger): Unit = {
     val buildOptions = buildOptionsOrExit(options)
 
-    if options.shared.scope.test then
+    if options.shared.scope.test.nonEmpty then
       logger.message(
         s"""$warnPrefix Including the test scope does not change the behaviour of this command. 
            |$warnPrefix Test scope inputs are formatted, regardless.""".stripMargin

modules/cli/src/main/scala/scala/cli/commands/package0/Package.scala

@@ -88,7 +88,7 @@ object Package extends ScalaCommand[PackageOptions] with BuildCommandHelpers {
         configDb.get(Keys.actions).getOrElse(None)
       )
 
-    val withTestScope = options.shared.scope.test
+    val withTestScope = options.shared.scope.test.getOrElse(false)
     if options.watch.watchMode then {
       var expectedModifyEpochSecondOpt = Option.empty[Long]
       val watcher = Build.watch(

modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala

@@ -266,7 +266,7 @@ object Publish extends ScalaCommand[PublishOptions] with BuildCommandHelpers {
       () => configDb,
       options.mainClass,
       dummy = options.sharedPublish.dummy,
-      buildTests = options.shared.scope.test
+      buildTests = options.shared.scope.test.getOrElse(false)
     )
   }
 

modules/cli/src/main/scala/scala/cli/commands/publish/PublishLocal.scala

@@ -86,7 +86,7 @@ object PublishLocal extends ScalaCommand[PublishLocalOptions] {
       configDb = () => ConfigDb.empty, // shouldn't be used, no need of repo credentials here
       mainClassOptions = options.mainClass,
       dummy = options.sharedPublish.dummy,
-      buildTests = options.shared.scope.test
+      buildTests = options.shared.scope.test.getOrElse(false)
     )
   }
 }

modules/cli/src/main/scala/scala/cli/commands/repl/Repl.scala

@@ -190,10 +190,11 @@ object Repl extends ScalaCommand[ReplOptions] with BuildCommandHelpers {
         configDb.get(Keys.actions).getOrElse(None)
       )
 
+    val shouldBuildTestScope = options.shared.scope.test.getOrElse(false)
     if (inputs.isEmpty) {
       val allArtifacts =
         Seq(initialBuildOptions.artifacts(logger, Scope.Main).orExit(logger)) ++
-          (if options.shared.scope.test
+          (if shouldBuildTestScope
            then Seq(initialBuildOptions.artifacts(logger, Scope.Test).orExit(logger))
            else Nil)
       // synchronizing, so that multiple presses to enter (handled by WatchUtil.waitForCtrlC)
@@ -224,7 +225,7 @@ object Repl extends ScalaCommand[ReplOptions] with BuildCommandHelpers {
         None,
         logger,
         crossBuilds = cross,
-        buildTests = options.shared.scope.test,
+        buildTests = shouldBuildTestScope,
         partial = None,
         actionableDiagnostics = actionableDiagnostics,
         postAction = () => WatchUtil.printWatchMessage()
@@ -252,7 +253,7 @@ object Repl extends ScalaCommand[ReplOptions] with BuildCommandHelpers {
           None,
           logger,
           crossBuilds = cross,
-          buildTests = options.shared.scope.test,
+          buildTests = shouldBuildTestScope,
           partial = None,
           actionableDiagnostics = actionableDiagnostics
         )

modules/cli/src/main/scala/scala/cli/commands/run/Run.scala

@@ -233,6 +233,7 @@ object Run extends ScalaCommand[RunOptions] with BuildCommandHelpers {
         configDb.get(Keys.actions).getOrElse(None)
       )
 
+    val shouldBuildTestScope = options.shared.scope.test.getOrElse(false)
     if options.sharedRun.watch.watchMode then {
 
       /** A handle to the Runner process, used to kill the process if it's still alive when a change
@@ -258,7 +259,7 @@ object Run extends ScalaCommand[RunOptions] with BuildCommandHelpers {
         docCompilerMakerOpt = None,
         logger = logger,
         crossBuilds = cross,
-        buildTests = options.shared.scope.test,
+        buildTests = shouldBuildTestScope,
         partial = None,
         actionableDiagnostics = actionableDiagnostics,
         postAction = () =>
@@ -331,7 +332,7 @@ object Run extends ScalaCommand[RunOptions] with BuildCommandHelpers {
         None,
         logger,
         crossBuilds = cross,
-        buildTests = options.shared.scope.test,
+        buildTests = shouldBuildTestScope,
         partial = None,
         actionableDiagnostics = actionableDiagnostics
       )