Skip to content

Commit ac5230a

Browse files
authored
chore: Bump outdated javac-semanticdb plugin to 0.10.0 (#3004)
This causes some issues when running Java via metals if there is no package defined (java semanticdb has some wierd stuff) Not sure why this isn't being bumped.
1 parent a962834 commit ac5230a

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

build.sc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -995,6 +995,7 @@ trait CliIntegration extends SbtModule with ScalaCliPublishModule with HasTests
995995
| def scalaNativeVersion = "${Deps.Versions.scalaNative}"
996996
| def scalaNativeVersion04 = "${Deps.Versions.scalaNative04}"
997997
| def scalaNativeVersion05 = "${Deps.Versions.scalaNative05}"
998+
| def semanticDbJavacPluginVersion = "${Deps.semanticDbJavac.dep.version}"
998999
| def ammoniteVersion = "${Deps.ammonite.dep.version}"
9991000
| def defaultGraalVMJavaVersion = "${deps.graalVmJavaVersion}"
10001001
| def defaultGraalVMVersion = "${deps.graalVmVersion}"

modules/integration/src/test/scala/scala/cli/integration/SemanticDbTestDefinitions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ trait SemanticDbTestDefinitions { _: CompileTestDefinitions =>
4444
.flatMap(opt => List("--javac-opt", opt))
4545
val javaSemDbOptions = Seq(
4646
"--javac-plugin",
47-
"com.sourcegraph:semanticdb-javac:0.7.4",
47+
s"com.sourcegraph:semanticdb-javac:${Constants.semanticDbJavacPluginVersion}",
4848
"--javac-opt",
4949
s"-Xplugin:semanticdb -sourceroot:$root -targetroot:javac-classes-directory"
5050
) ++ exports

project/deps.sc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ object Deps {
108108
def scalaPackager = "0.1.29"
109109
def signingCli = "0.2.3"
110110
def signingCliJvmVersion = 17
111+
def javaSemanticdb = "0.10.0"
111112
def javaClassName = "0.1.3"
112113
def bloop = "1.5.17-sc-2"
113114
}
@@ -187,7 +188,7 @@ object Deps {
187188
def scalaPackagerCli = ivy"org.virtuslab:scala-packager-cli_2.13:${Versions.scalaPackager}"
188189
def scalaPy = ivy"dev.scalapy::scalapy-core::0.5.3"
189190
def scalaReflect(sv: String) = ivy"org.scala-lang:scala-reflect:$sv"
190-
def semanticDbJavac = ivy"com.sourcegraph:semanticdb-javac:0.7.4"
191+
def semanticDbJavac = ivy"com.sourcegraph:semanticdb-javac:${Versions.javaSemanticdb}"
191192
def semanticDbScalac = ivy"org.scalameta:::semanticdb-scalac:${Versions.scalaMeta}"
192193
def signingCliShared =
193194
ivy"org.virtuslab.scala-cli-signing::shared:${Versions.signingCli}"

0 commit comments

Comments
 (0)