improvement: Use distinct on ScalacOpt (#3139)

tgodzik · web-flow · commit dab5d9e9b6c7 · 2024-09-02T10:33:34.000+02:00
I am still getting an issue with multiple same plugin options and my guess is that the distinct doesn't work, especially that it is hard to figure out what can actually be contained there. Moving distinct to the end should be a much safer option. Related to #2708
diff --git a/modules/build/src/main/scala/scala/build/Build.scala b/modules/build/src/main/scala/scala/build/Build.scala
@@ -862,10 +862,10 @@ object Build {
           )
         }
 
-        val pluginScalacOptions = scalaArtifacts.compilerPlugins.distinct.map {
+        val pluginScalacOptions = scalaArtifacts.compilerPlugins.map {
           case (_, _, path) =>
             ScalacOpt(s"-Xplugin:$path")
-        }
+        }.distinct
 
         val semanticDbTargetRootOptions: Seq[ScalacOpt] =
           (semanticDbTargetRoot match

Original file line number	Diff line number	Diff line change
`@@ -862,10 +862,10 @@ object Build {`
`862`	`862`	`)`
`863`	`863`	`}`
`864`	`864`
`865`		`- val pluginScalacOptions = scalaArtifacts.compilerPlugins.distinct.map {`
	`865`	`+ val pluginScalacOptions = scalaArtifacts.compilerPlugins.map {`
`866`	`866`	`case (_, _, path) =>`
`867`	`867`	`ScalacOpt(s"-Xplugin:$path")`
`868`		`- }`
	`868`	`+ }.distinct`
`869`	`869`
`870`	`870`	`val semanticDbTargetRootOptions: Seq[ScalacOpt] =`
`871`	`871`	`(semanticDbTargetRoot match`