Skip to content

Commit dddef7f

Browse files
authored
Include scanning the .exe launcher in the release procedure (#3081)
1 parent e0ab43b commit dddef7f

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

.github/release/windows-antimalware-analysis.md

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@ As those eventually do pull through, we can't do much about it.
1111

1212
## Submitting a file for analysis
1313

14-
After going through the [release procedure](release-procedure.md), we need to submit the MSI installer for analysis.
15-
Download the `scala-cli-x86_64-pc-win32.msi` and upload it using this [service](https://www.microsoft.com/en-us/wdsi/filesubmission).
16-
14+
After going through the [release procedure](release-procedure.md), we need to submit the MSI installer
15+
and the EXE launcher for analysis:
16+
- [ ] Download the `scala-cli-x86_64-pc-win32.msi` and upload it using [this service](https://www.microsoft.com/en-us/wdsi/filesubmission).
17+
- [ ] Download the `scala-cli-x86_64-pc-win32.zip`, extract it and upload `scala-cli.exe` using [the same service](https://www.microsoft.com/en-us/wdsi/filesubmission).
1718
You will need to log in using your company account authorised by the VirtusLab IT division.
18-
If you don't have one or if the one you do have doesn't have the right permissions
19+
If you don't have one or if the one you do have doesn't have the right permissions
1920
(even though you are a maintainer of the Scala CLI repository), be sure to reach out to IT.
2021

2122
## Submission form
@@ -48,13 +49,20 @@ Microsoft Defender SmartScreen prevented an unrecognised app from starting.
4849
The version number for the Scala CLI release.
4950

5051
#### Additional information
51-
Paste the following, fixing swapping out the version number and release link accordingly.
52+
When uploading the installer (`*.msi`), paste the following, fixing swapping out the version number and release link accordingly.
5253
```text
5354
This is the Scala CLI v<version number> installer for Microsoft Windows.
5455
Scala CLI is the official runner of the Scala programming language.
5556
For more information check https://github.com/VirtusLab/scala-cli/releases/tag/v<version number>
5657
```
5758

59+
For the launcher (`*.exe`), use the (almost identical) following text:
60+
```text
61+
This is the Scala CLI v<version number> launcher for Microsoft Windows.
62+
Scala CLI is the official runner of the Scala programming language.
63+
For more information check https://github.com/VirtusLab/scala-cli/releases/tag/v<version number>
64+
```
65+
5866
Click continue.
5967

6068
![image](img/submit-for-malware-analysis-4.png)

0 commit comments

Comments
 (0)