Revert "fix: do not dup invalid file descriptor in compile method (#269)"

plusvic · plusvic · commit e6b10ebfec32 · 2025-04-30T11:15:28.000+02:00
This reverts commit df256bc.
diff --git a/yara-python.c b/yara-python.c
@@ -2830,12 +2830,12 @@ static PyObject* yara_compile(
     }
     else if (file != NULL)
     {
-      fd = PyObject_AsFileDescriptor(file);
+      fd = dup(PyObject_AsFileDescriptor(file));
 
       if (fd != -1)
       {
         Py_BEGIN_ALLOW_THREADS
-        fh = fdopen(dup(fd), "r");
+        fh = fdopen(fd, "r");
         error = yr_compiler_add_file(compiler, fh, NULL, NULL);
         fclose(fh);
         Py_END_ALLOW_THREADS

Original file line number	Diff line number	Diff line change
`@@ -2830,12 +2830,12 @@ static PyObject* yara_compile(`
`2830`	`2830`	`}`
`2831`	`2831`	`else if (file != NULL)`
`2832`	`2832`	`{`
`2833`		`- fd = PyObject_AsFileDescriptor(file);`
	`2833`	`+ fd = dup(PyObject_AsFileDescriptor(file));`
`2834`	`2834`
`2835`	`2835`	`if (fd != -1)`
`2836`	`2836`	`{`
`2837`	`2837`	`Py_BEGIN_ALLOW_THREADS`
`2838`		`- fh = fdopen(dup(fd), "r");`
	`2838`	`+ fh = fdopen(fd, "r");`
`2839`	`2839`	`error = yr_compiler_add_file(compiler, fh, NULL, NULL);`
`2840`	`2840`	`fclose(fh);`
`2841`	`2841`	`Py_END_ALLOW_THREADS`